From f9786bf8b786eeef3c972929f7483c7fb52a8829 Mon Sep 17 00:00:00 2001 From: "Aaron S. Hawley" Date: Thu, 4 Apr 2019 13:58:37 -0400 Subject: [PATCH] Remove field RewriteRule.name It's not clear what this class member is for. Because of the lexical scoping rules in Scala, it can become an unfortunate name-collision when users write code that uses the same variable name in the anonymous class. --- build.sbt | 7 +++++++ .../src/main/scala/scala/xml/transform/RewriteRule.scala | 2 -- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/build.sbt b/build.sbt index cb9d1f576..14a058f69 100644 --- a/build.sbt +++ b/build.sbt @@ -21,6 +21,13 @@ lazy val xml = crossProject(JSPlatform, JVMPlatform) scalacOptions ++= "-deprecation:false -feature -Xlint:-stars-align,-nullary-unit,_".split("\\s+").to[Seq], scalacOptions in Test += "-Xxml:coalescing", + mimaBinaryIssueFilters ++= { + import com.typesafe.tools.mima.core._ + import com.typesafe.tools.mima.core.ProblemFilters._ + Seq( + exclude[DirectMissingMethodProblem]("scala.xml.transform.RewriteRule.name") + ) + }, mimaPreviousVersion := { if (System.getenv("SCALAJS_VERSION") == "1.0.0-M6") None // No such release yet else Some("1.1.1") diff --git a/shared/src/main/scala/scala/xml/transform/RewriteRule.scala b/shared/src/main/scala/scala/xml/transform/RewriteRule.scala index dd0d8895b..315be859d 100644 --- a/shared/src/main/scala/scala/xml/transform/RewriteRule.scala +++ b/shared/src/main/scala/scala/xml/transform/RewriteRule.scala @@ -20,8 +20,6 @@ import scala.collection.Seq * @author Burak Emir */ abstract class RewriteRule extends BasicTransformer { - /** a name for this rewrite rule */ - val name = this.toString() override def transform(ns: Seq[Node]): Seq[Node] = super.transform(ns) override def transform(n: Node): Seq[Node] = n }