Skip to content

integrate-then-merge by bot #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adriaanm opened this issue Jan 27, 2015 · 3 comments
Closed

integrate-then-merge by bot #9

adriaanm opened this issue Jan 27, 2015 · 3 comments

Comments

@adriaanm
Copy link
Contributor

add /integrate command, which launches the integration job on the merge commit of PR into target branch, actually merges PR on success

TODO: figure out smoothest way to do this -- ideally, we'd build actual merge comment and then push to repo, but that would mean not using the "merge button", closing the PR instead... maybe that's the way to go

@SethTisue
Copy link
Member

fwiw, I would be sorry to lose the purple "merged" indicators on GitHub

@VladUreche
Copy link

What @adriaanm is describing is the @bors bot from the Rust team. EDIT: The bot code is open source, available here: https://github.com/buildbot/buildbot

@SethTisue
Copy link
Member

GitHub has auto-merge now

it also has a setting to require a branch be up to date before it's merged. we could enable that, but it's not clear it's worth it. 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants