Skip to content

Commit 9e7cb40

Browse files
committed
refresh scalafmt fork
to a much newer version that doesn't have so many idiosyncratic dependencies
1 parent 9617ec4 commit 9e7cb40

File tree

2 files changed

+82
-103
lines changed

2 files changed

+82
-103
lines changed

configs/community.dbuild

Lines changed: 78 additions & 97 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
// - scala
55
// - scala.main
66
// - scala.main.jawn_0_10
7-
// - scala.main.jawn_0_10.scalameta_1
8-
// - scala.main.jawn_0_10.scalameta_2
7+
// - scala.main.jawn_0_10.metaconfig_new
8+
// - scala.main.jawn_0_10.metaconfig_old
99
// - scala.main.jawn_0_11
1010
// - scala.scalaz8
1111

@@ -15,11 +15,10 @@
1515
// but in the meantime the whole Typelevel ecosystem is moving onto
1616
// jawn 0.11, and the two versions are source-incompatible.
1717

18-
// the scalameta split is because we want to have both scalafmt
19-
// and scalafix, but the latter uses scalameta 2.x while the
20-
// former is stuck in scalameta 1.x land. (this is easy to
21-
// keep segregated since scalafmt and scalafix tend to be
22-
// build-level dependencies, not project-level dependencies.)
18+
// the metaconfig split is because we want to have both scalafmt
19+
// and scalafix, but they are on incompatible metaconfig versions.
20+
// (this is easy to keep segregated since scalafmt and scalafix tend
21+
// to be build-level dependencies, not project-level dependencies.)
2322

2423
// the scalaz 7/8 split is because both scalaz versions use (at least
2524
// some of) the same artifact names
@@ -1646,6 +1645,46 @@ build += {
16461645
check-missing: false
16471646
}
16481647

1648+
// forked (updated September 2017) to remove coursier.
1649+
// refreshing the fork should be approached with caution;
1650+
// see Olafur's remarks at
1651+
// https://github.com/scala/community-builds/issues/499#issuecomment-287307613
1652+
// about the instability of both scalameta and scalafix.
1653+
${vars.base} {
1654+
name: "scalameta"
1655+
uri: ${vars.uris.scalameta-uri}
1656+
// else, bintray stuff goes boom
1657+
extra.options: ["-Dsbt.prohibit.publish=true"]
1658+
extra.projects: ["scalametaJVM", "contribJVM", "semanticdbScalac"] // no Scala.js
1659+
extra.exclude: [
1660+
// we never build sbt plugins or benchmarks
1661+
"benchmarks"
1662+
]
1663+
// use right version-specific source directories regardless of our weird dbuild Scala version numbers
1664+
extra.commands: ${vars.default-commands} [
1665+
"set unmanagedSourceDirectories in (commonJVM, Compile) += (baseDirectory in commonJVM).value / \"src\" / \"main\" / \"scala-2.12\""
1666+
"set unmanagedSourceDirectories in (dialectsJVM, Compile) += (baseDirectory in dialectsJVM).value / \"src\" / \"main\" / \"scala-2.12\""
1667+
"set unmanagedSourceDirectories in (scalametaJVM, Compile) += (baseDirectory in scalametaJVM).value / \"src\" / \"main\" / \"scala-2.12\""
1668+
"set unmanagedSourceDirectories in (semanticdbScalac, Compile) += (baseDirectory in semanticdbScalac).value / \"src\" / \"main\" / \"scala-2.12.5\""
1669+
]
1670+
}
1671+
1672+
${vars.base} {
1673+
name: "jsoniter-scala"
1674+
uri: ${vars.uris.jsoniter-scala-uri}
1675+
extra.sbt-version: ${vars.sbt-1-version}
1676+
extra.exclude: ["benchmark"]
1677+
}
1678+
1679+
${vars.base} {
1680+
name: "scalatex"
1681+
uri: ${vars.uris.scalatex-uri}
1682+
extra.exclude: [
1683+
"scalatexSbtPlugin" // we never build sbt plugins
1684+
"site", "readme", "scrollspy" // these use Scala.js
1685+
]
1686+
}
1687+
16491688
]}
16501689

16511690
//// space: jawn_0_10
@@ -1764,13 +1803,6 @@ build += {
17641803
extra.projects: ["upickleJVM"]
17651804
}
17661805

1767-
${vars.base} {
1768-
name: "jsoniter-scala"
1769-
uri: ${vars.uris.jsoniter-scala-uri}
1770-
extra.sbt-version: ${vars.sbt-1-version}
1771-
extra.exclude: ["benchmark"]
1772-
}
1773-
17741806
// dependency of scaladex. depends on upickle
17751807
${vars.base} {
17761808
name: "autowire"
@@ -1815,16 +1847,6 @@ build += {
18151847
]
18161848
}
18171849

1818-
// depends on ammonite-ops
1819-
${vars.base} {
1820-
name: "scalatex"
1821-
uri: ${vars.uris.scalatex-uri}
1822-
extra.exclude: [
1823-
"scalatexSbtPlugin" // we never build sbt plugins
1824-
"site", "readme", "scrollspy" // these use Scala.js
1825-
]
1826-
}
1827-
18281850
// see also ammonite-ops.
18291851
// frozen (April 2018) at a March 2018 commit before a problematic upickle
18301852
// upgrade; see also upickle
@@ -2006,11 +2028,11 @@ build += {
20062028

20072029
]}
20082030

2009-
//// space: scalameta_1
2031+
//// space: metaconfig_new
20102032

20112033
build += {
20122034

2013-
space: scala.main.jawn_0_10.scalameta_1
2035+
space: scala.main.jawn_0_10.metaconfig_new
20142036

20152037
check-missing: [ true, false ]
20162038
cross-version: [ disabled, standard ]
@@ -2019,64 +2041,42 @@ build += {
20192041

20202042
projects: [
20212043

2022-
// forked (refreshed November 2017) to disable bintray stuff, IntelliJ stuff,
2023-
// and to remove a failing git-based test
2044+
// forked (June 2018) to disable IntelliJ stuff
20242045
${vars.base} {
20252046
name: "scalafmt"
20262047
uri: ${vars.uris.scalafmt-uri}
20272048
extra.projects: ["coreJVM", "cli", "tests"]
2028-
}
2029-
2030-
// dependency of scalafmt. frozen at an old version because that's what
2031-
// scalafmt expects. (over in the other scalameta space, scalafix expects
2032-
// a newer version.)
2033-
${vars.base} {
2034-
name: "metaconfig-old"
2035-
uri: ${vars.uris.metaconfig-old-uri}
2036-
extra.projects: ["metaconfig-hoconJVM", "metaconfig-typesafe-config"] // no Scala.js plz
2037-
}
2038-
2039-
// dependency of scalafmt
2040-
// forked (July 2017) for dbuild friendliness
2041-
${vars.base} {
2042-
name: "meta-paradise"
2043-
uri: ${vars.uris.meta-paradise-uri}
2044-
// only goal right now (November 2017) is to get scalafmt in, so, let's just
2045-
// add the project we actually need and not worry about the rest
2046-
extra.projects: ["paradise"]
2047-
// use right version-specific source directory regardless of our weird dbuild Scala version number
20482049
extra.commands: ${vars.default-commands} [
2049-
"set unmanagedSourceDirectories in (paradise, Compile) += (baseDirectory in paradise).value / \"src\" / \"main\" / \"scala-2.12.2\""
2050+
"set every bintrayReleaseOnPublish := false"
2051+
// one test failure, maybe xml-related, I should report it upstream
2052+
"set excludeFilter in (Test, unmanagedSources) in tests := HiddenFileFilter || \"FormatTests.scala\""
20502053
]
20512054
}
20522055

2053-
// dependency of scalafmt
2056+
// dependency of scalafmt. frozen at an old version because that's what
2057+
// scalafmt expects
20542058
${vars.base} {
2055-
name: "scalameta-1"
2056-
uri: ${vars.uris.scalameta-1-uri}
2057-
// else, bintray stuff goes boom
2058-
extra.options: ["-Dsbt.prohibit.publish=true"]
2059-
extra.projects: ["scalametaJVM", "testkit"] // no Scala.js. just the minimum scalafmt needs?
2060-
extra.exclude: [
2061-
// we never build sbt plugins or benchmarks
2062-
"benchmarks"
2059+
name: "metaconfig-new"
2060+
uri: ${vars.uris.metaconfig-new-uri}
2061+
extra.projects: ["metaconfig-hoconJVM", "metaconfig-typesafe-config"] // no Scala.js plz
2062+
// I guess dbuild is getting confused by the extra _1.13?
2063+
deps.ignore: ["com.github.alexarchambault#scalacheck-shapeless"]
2064+
deps.inject: ${vars.base.deps.inject} [
2065+
"com.github.alexarchambault#scalacheck-shapeless_1.13"
20632066
]
2064-
extra.commands: ${vars.default-commands} [
2065-
// use right version-specific source directories regardless of our weird dbuild Scala version numbers
2066-
"set unmanagedSourceDirectories in (commonJVM, Compile) += (baseDirectory in commonJVM).value / \"src\" / \"main\" / \"scala-2.12\""
2067-
"set unmanagedSourceDirectories in (dialectsJVM, Compile) += (baseDirectory in dialectsJVM).value / \"src\" / \"main\" / \"scala-2.12\""
2068-
"set unmanagedSourceDirectories in (scalametaJVM, Compile) += (baseDirectory in scalametaJVM).value / \"src\" / \"main\" / \"scala-2.12\""
2069-
"set unmanagedSourceDirectories in (scalahost, Compile) += (baseDirectory in scalahost).value / \"src\" / \"main\" / \"scala-2.12.1\""
2067+
check-missing: false
2068+
extra.settings: ${vars.base.extra.settings} [
2069+
"conflictWarning in ThisBuild := ConflictWarning.disable"
20702070
]
20712071
}
20722072

20732073
]}
20742074

2075-
//// space: scalameta_2
2075+
//// space: metaconfig-old
20762076

20772077
build += {
20782078

2079-
space: scala.main.jawn_0_10.scalameta_2
2079+
space: scala.main.jawn_0_10.metaconfig_old
20802080

20812081
check-missing: [ true, false ]
20822082
cross-version: [ disabled, standard ]
@@ -2085,30 +2085,6 @@ build += {
20852085

20862086
projects: [
20872087

2088-
// forked (updated September 2017) to remove coursier.
2089-
// refreshing the fork should be approached with caution;
2090-
// see Olafur's remarks at
2091-
// https://github.com/scala/community-builds/issues/499#issuecomment-287307613
2092-
// about the instability of both scalameta and scalafix.
2093-
${vars.base} {
2094-
name: "scalameta-2"
2095-
uri: ${vars.uris.scalameta-2-uri}
2096-
// else, bintray stuff goes boom
2097-
extra.options: ["-Dsbt.prohibit.publish=true"]
2098-
extra.projects: ["scalametaJVM", "contribJVM", "semanticdbScalac"] // no Scala.js
2099-
extra.exclude: [
2100-
// we never build sbt plugins or benchmarks
2101-
"benchmarks"
2102-
]
2103-
// use right version-specific source directories regardless of our weird dbuild Scala version numbers
2104-
extra.commands: ${vars.default-commands} [
2105-
"set unmanagedSourceDirectories in (commonJVM, Compile) += (baseDirectory in commonJVM).value / \"src\" / \"main\" / \"scala-2.12\""
2106-
"set unmanagedSourceDirectories in (dialectsJVM, Compile) += (baseDirectory in dialectsJVM).value / \"src\" / \"main\" / \"scala-2.12\""
2107-
"set unmanagedSourceDirectories in (scalametaJVM, Compile) += (baseDirectory in scalametaJVM).value / \"src\" / \"main\" / \"scala-2.12\""
2108-
"set unmanagedSourceDirectories in (semanticdbScalac, Compile) += (baseDirectory in semanticdbScalac).value / \"src\" / \"main\" / \"scala-2.12.5\""
2109-
]
2110-
}
2111-
21122088
// adding (September 2017) because scalafix's "cli" subproject uses it.
21132089
// forked to remove coursier and upgrade sbt-bintray
21142090
${vars.base} {
@@ -2122,15 +2098,20 @@ build += {
21222098
extra.projects: ["runtime"]
21232099
}
21242100

2125-
// dependency of scalafix. frozen (April 2018) at v0.6.0 since newer commits break
2126-
// scalafix. presumably this is a temporarily transitional state and we should attempt
2127-
// to unfreeze once things settle down. (the commit descriptions indicate this is part of
2128-
// an effort to move scalafmt onto newer versions of things -- it'd be great to have
2129-
// scalafmt and scalafix in the same space.)
2101+
// dependency of scalafix, frozen (June 2018) at v0.8.3 (the version scalafix uses)
21302102
${vars.base} {
2131-
name: "metaconfig-new"
2132-
uri: ${vars.uris.metaconfig-new-uri}
2103+
name: "metaconfig-old"
2104+
uri: ${vars.uris.metaconfig-old-uri}
21332105
extra.projects: ["metaconfig-hoconJVM", "metaconfig-typesafe-config"] // no Scala.js plz
2106+
// I guess dbuild is getting confused by the extra _1.13?
2107+
deps.ignore: ["com.github.alexarchambault#scalacheck-shapeless"]
2108+
deps.inject: ${vars.base.deps.inject} [
2109+
"com.github.alexarchambault#scalacheck-shapeless_1.13"
2110+
]
2111+
check-missing: false
2112+
extra.settings: ${vars.base.extra.settings} [
2113+
"conflictWarning in ThisBuild := ConflictWarning.disable"
2114+
]
21342115
}
21352116

21362117
// (here in this space because of ammonite-ops dependency)

configs/project-refs.conf

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,8 @@ vars.uris: {
7070
macro-compat-uri: "https://github.com/milessabin/macro-compat.git"
7171
macro-paradise-uri: "https://github.com/scalacommunitybuild/paradise.git#community-build-2.12"
7272
magnolia-uri: "https://github.com/propensive/magnolia.git"
73-
meta-paradise-uri: "https://github.com/scalacommunitybuild/paradise.git#community-build-2.12-meta-paradise"
74-
metaconfig-new-uri: "https://github.com/olafurpg/metaconfig.git#v0.6.0"
75-
metaconfig-old-uri: "https://github.com/olafurpg/metaconfig.git#b13e6bbbf"
73+
metaconfig-new-uri: "https://github.com/olafurpg/metaconfig.git#v0.7.2"
74+
metaconfig-old-uri: "https://github.com/olafurpg/metaconfig.git#v0.6.0"
7675
metrics-scala-uri: "https://github.com/erikvanoosten/metrics-scala.git"
7776
mima-uri: "https://github.com/lightbend/migration-manager.git"
7877
minitest-uri: "https://github.com/monix/minitest.git"
@@ -127,12 +126,11 @@ vars.uris: {
127126
scalachess-uri: "https://github.com/ornicar/scalachess.git"
128127
scaladex-uri: "https://github.com/scalacenter/scaladex.git#8f943f1961" # was master
129128
scalafix-uri: "https://github.com/scalacommunitybuild/scalafix.git#community-build-2.12"
130-
scalafmt-uri: "https://github.com/scalacommunitybuild/scalafmt.git#community-build-2.12"
129+
scalafmt-uri: "https://github.com/SethTisue/scalafmt.git#community-build-2.12"
131130
scalaj-http-uri: "https://github.com/scalaj/scalaj-http.git"
132131
scalajson-uri: "https://github.com/mdedetrich/scalajson.git"
133132
scalalib-uri: "https://github.com/ornicar/scalalib.git"
134-
scalameta-1-uri: "https://github.com/scalacommunitybuild/scalameta.git#community-build-2.12-scalameta1" # was v1.7.0
135-
scalameta-2-uri: "https://github.com/scalacommunitybuild/scalameta.git#community-build-2.12"
133+
scalameta-uri: "https://github.com/scalacommunitybuild/scalameta.git#community-build-2.12"
136134
scalameter-uri: "https://github.com/scalameter/scalameter.git"
137135
scalamock-uri: "https://github.com/paulbutcher/ScalaMock.git#1e84ffe" # was master
138136
scalapb-lenses-uri: "https://github.com/scalapb/Lenses.git#410b853c0" # was master

0 commit comments

Comments
 (0)