Skip to content

Deprecate variadic version of += operator on Growable #10828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
julienrf opened this issue Apr 13, 2018 · 1 comment · Fixed by scala/scala#6719
Closed

Deprecate variadic version of += operator on Growable #10828

julienrf opened this issue Apr 13, 2018 · 1 comment · Fixed by scala/scala#6719

Comments

@julienrf
Copy link

We want to prevent users from using it so that the transition to non-auto-tupling will be easier.

See related discussion here: scala/scala3#4311 (comment)

@lrytz lrytz added this to the 2.13.0-M4 milestone Apr 19, 2018
@lrytz
Copy link
Member

lrytz commented Apr 19, 2018

Also remove the overload in LongMap and add an add a final override, as suggested by Sébastien scala/scala3#4311 (comment). The scala inliner handles it (and eliminates the boxing and tuple allocation), but of course only if it's enabled (collection users need to enable -opt:l:inline '-opt-inline-from:scala.collection.**')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants