Skip to content

Commit 2070f98

Browse files
committed
Address last comments.
1 parent a933c2c commit 2070f98

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

_config.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -68,4 +68,4 @@ versions:
6868
scalaJSBinary: 1
6969
scalaJS06x: 0.6.33
7070
scalaJS06xBinary: 0.6
71-
scalaJSDOM: 2.1.0
71+
scalaJSDOM: 2.4.0

doc/tutorial/laminar.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ In this second tutorial, we learn how to develop UIs in Scala.js with [Laminar](
88
We start here with the project setup developed in the previous tutorial about [Setting up Scala.js with Vite](./scalajs-vite.html).
99
To follow along this tutorial, either use the result of the previous tutorial, or checkout [the scalajs-vite-end-state branch](https://github.com/sjrd/scalajs-sbt-vite-laminar-chartjs-example/tree/scalajs-vite-end-state) of the accompanying repo.
1010

11-
If you prefer to navigate the end result for this tutorial directly, checkout [the laminar-end-state branch](https://github.com/sjrd/scalajs-sbt-vite-laminar-chartjs-example/tree/laminar-end-state) instead.
11+
If you prefer to look at the end result for this tutorial directly, checkout [the laminar-end-state branch](https://github.com/sjrd/scalajs-sbt-vite-laminar-chartjs-example/tree/laminar-end-state) instead.
1212

1313
[See the final result in action and fiddle with the code in Scribble](https://scribble.ninja/u/sjrd/ddueiaxghmbmbnbpzggmkwwmpigc)
1414

@@ -270,7 +270,7 @@ We first add the following dependency on [MUnit](https://scalameta.org/munit/),
270270
)
271271
{% endhighlight %}
272272

273-
After re-importing the project in the IDE (which should be prompted), we create a new file `src/test/scala/livechart/ModelTest.scala`.
273+
After re-importing the project in the IDE, we create a new file `src/test/scala/livechart/ModelTest.scala`.
274274
We write an elementary test for `DataItem.fullPrice` as follows:
275275

276276
{% highlight scala %}

doc/tutorial/scalablytyped.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ In this third tutorial, we learn how to integrate JavaScript libraries with [Sca
88
We start here with the project developed in the previous tutorial about [UI development with Laminar](./laminar.html).
99
To follow along this tutorial, either use the result of the previous tutorial, or checkout [the laminar-end-state branch](https://github.com/sjrd/scalajs-sbt-vite-laminar-chartjs-example/tree/laminar-end-state) of the accompanying repo.
1010

11-
If you prefer to navigate the end result for this tutorial directly, checkout [the scalablytyped-end-state branch](https://github.com/sjrd/scalajs-sbt-vite-laminar-chartjs-example/tree/scalablytyped-end-state) instead.
11+
If you prefer to look at the end result for this tutorial directly, checkout [the scalablytyped-end-state branch](https://github.com/sjrd/scalajs-sbt-vite-laminar-chartjs-example/tree/scalablytyped-end-state) instead.
1212

1313
There are no playgrounds in [Scribble](https://scribble.ninja/) for this tutorial because it does not support ScalablyTyped.
1414
You will need a local project to follow along.

doc/tutorial/scalajs-vite.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ We also configure it to build a minimal bundle for production.
1010
Going through this tutorial will make sure you understand the basic building blocks.
1111
If you prefer to skip this step and directly write Scala.js code, you may jump to [Getting Started with Scala.js and Laminar](./laminar-scalablytyped.html).
1212

13-
If you prefer to navigate the end result for this tutorial directly, checkout [the scalajs-vite-end-state branch](https://github.com/sjrd/scalajs-sbt-vite-laminar-chartjs-example/tree/scalajs-vite-end-state) instead of creating everything from scratch.
13+
If you prefer to look at the end result for this tutorial directly, checkout [the scalajs-vite-end-state branch](https://github.com/sjrd/scalajs-sbt-vite-laminar-chartjs-example/tree/scalajs-vite-end-state) instead of creating everything from scratch.
1414

1515
## Prerequisites
1616

@@ -110,7 +110,7 @@ sbt.version=1.8.2
110110
* `project/plugins.sbt`: declare sbt plugins; in this case, only sbt-scalajs
111111

112112
{% highlight scala %}
113-
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "1.13.0")
113+
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "{{ site.versions.scalaJS }}")
114114
{% endhighlight %}
115115

116116
At the root of our `livechart/` project, we add one file: `build.sbt`.
@@ -144,7 +144,7 @@ lazy val livechart = project.in(file("."))
144144
/* Depend on the scalajs-dom library.
145145
* It provides static types for the browser DOM APIs.
146146
*/
147-
libraryDependencies += "org.scala-js" %%% "scalajs-dom" % "2.4.0",
147+
libraryDependencies += "org.scala-js" %%% "scalajs-dom" % "{{ site.versions.scalaJSDOM }}",
148148
)
149149
{% endhighlight %}
150150

0 commit comments

Comments
 (0)