From e33e10114769fd39fc562d6773bc4db73c041dcf Mon Sep 17 00:00:00 2001 From: matil019 Date: Mon, 29 Nov 2021 16:43:02 +0900 Subject: [PATCH 1/2] Change the result type of ReadableStream#pipeTo to js.Promise[Unit] According to the whatwg spec, it should return a Promise. --- dom/src/main/scala/org/scalajs/dom/ReadableStream.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dom/src/main/scala/org/scalajs/dom/ReadableStream.scala b/dom/src/main/scala/org/scalajs/dom/ReadableStream.scala index cc6cd9973..8d553d83b 100644 --- a/dom/src/main/scala/org/scalajs/dom/ReadableStream.scala +++ b/dom/src/main/scala/org/scalajs/dom/ReadableStream.scala @@ -75,7 +75,7 @@ trait ReadableStream[+T] extends js.Object { * * //todo: determine the type of options */ - def pipeTo(dest: WriteableStream[T], options: Any = js.native): Unit = js.native + def pipeTo(dest: WriteableStream[T], options: Any = js.native): js.Promise[Unit] = js.native /** See [[https://streams.spec.whatwg.org/#rs-tee ΒΆ3.2.4.6. tee()]] of whatwg streams spec. * From 49c89d28c023dc14f607a6ed82fc8c929dac4fa3 Mon Sep 17 00:00:00 2001 From: matil019 Date: Mon, 29 Nov 2021 16:49:08 +0900 Subject: [PATCH 2/2] Update api-reports --- api-reports/2_12.txt | 2 +- api-reports/2_13.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/api-reports/2_12.txt b/api-reports/2_12.txt index bcf31dc83..82b95762e 100644 --- a/api-reports/2_12.txt +++ b/api-reports/2_12.txt @@ -15851,7 +15851,7 @@ ReadableStream[JT] def cancel(reason: js.UndefOr[Any]?): js.Promise[Unit] ReadableStream[JT] def getReader(): ReadableStreamReader[T] ReadableStream[JT] def locked: Boolean ReadableStream[JT] def pipeThrough[U](pair: Any, options: Any?): ReadableStream[U] -ReadableStream[JT] def pipeTo(dest: WriteableStream[T], options: Any?): Unit +ReadableStream[JT] def pipeTo(dest: WriteableStream[T], options: Any?): js.Promise[Unit] ReadableStream[JT] def tee(): js.Array[_ <: ReadableStream[T]] ReadableStream[SO] def apply[T](underlyingSource: js.UndefOr[ReadableStreamUnderlyingSource[T]]?, queuingStrategy: js.UndefOr[QueuingStrategy[T]]?): ReadableStream[T] ReadableStreamController[JC] def close(): Unit diff --git a/api-reports/2_13.txt b/api-reports/2_13.txt index bcf31dc83..82b95762e 100644 --- a/api-reports/2_13.txt +++ b/api-reports/2_13.txt @@ -15851,7 +15851,7 @@ ReadableStream[JT] def cancel(reason: js.UndefOr[Any]?): js.Promise[Unit] ReadableStream[JT] def getReader(): ReadableStreamReader[T] ReadableStream[JT] def locked: Boolean ReadableStream[JT] def pipeThrough[U](pair: Any, options: Any?): ReadableStream[U] -ReadableStream[JT] def pipeTo(dest: WriteableStream[T], options: Any?): Unit +ReadableStream[JT] def pipeTo(dest: WriteableStream[T], options: Any?): js.Promise[Unit] ReadableStream[JT] def tee(): js.Array[_ <: ReadableStream[T]] ReadableStream[SO] def apply[T](underlyingSource: js.UndefOr[ReadableStreamUnderlyingSource[T]]?, queuingStrategy: js.UndefOr[QueuingStrategy[T]]?): ReadableStream[T] ReadableStreamController[JC] def close(): Unit