Skip to content

Commit dd5dfc2

Browse files
japgollyjapgolly
committed
IDB cursor result types were incorrectly abstract
1 parent a96c76d commit dd5dfc2

File tree

3 files changed

+14
-14
lines changed

3 files changed

+14
-14
lines changed

‎api-reports/2_12.txt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14061,8 +14061,8 @@ IDBIndex[JC] def keyPath: IDBKeyPath
1406114061
IDBIndex[JC] val multiEntry: Boolean
1406214062
IDBIndex[JC] def name: String
1406314063
IDBIndex[JC] def objectStore: IDBObjectStore
14064-
IDBIndex[JC] def openCursor(range: js.UndefOr[IDBKeyRange | IDBKey]?, direction: js.UndefOr[IDBCursorDirection]?): IDBRequest[S, IDBCursor[S]]
14065-
IDBIndex[JC] def openKeyCursor(range: js.UndefOr[IDBKeyRange | IDBKey]?, direction: js.UndefOr[IDBCursorDirection]?): IDBRequest[S, IDBCursorReadOnly[S]]
14064+
IDBIndex[JC] def openCursor(range: js.UndefOr[IDBKeyRange | IDBKey]?, direction: js.UndefOr[IDBCursorDirection]?): IDBRequest[S, IDBCursorWithValue[S]]
14065+
IDBIndex[JC] def openKeyCursor(range: js.UndefOr[IDBKeyRange | IDBKey]?, direction: js.UndefOr[IDBCursorDirection]?): IDBRequest[S, IDBCursor[S]]
1406614066
IDBIndex[JC] def unique: Boolean
1406714067
IDBKeyRange[JC] def lower: IDBKey
1406814068
IDBKeyRange[JC] def lowerOpen: Boolean
@@ -14086,8 +14086,8 @@ IDBObjectStore[JC] def index(name: String): IDBIndex
1408614086
IDBObjectStore[JC] def indexNames: DOMStringList
1408714087
IDBObjectStore[JC] def keyPath: IDBKeyPath
1408814088
IDBObjectStore[JC] def name: String
14089-
IDBObjectStore[JC] def openCursor(range: js.UndefOr[IDBKeyRange | IDBKey]?, direction: js.UndefOr[IDBCursorDirection]?): IDBRequest[S, IDBCursor[S]]
14090-
IDBObjectStore[JC] def openKeyCursor(range: js.UndefOr[IDBKeyRange | IDBKey]?, direction: js.UndefOr[IDBCursorDirection]?): IDBRequest[S, IDBCursorReadOnly[S]]
14089+
IDBObjectStore[JC] def openCursor(range: js.UndefOr[IDBKeyRange | IDBKey]?, direction: js.UndefOr[IDBCursorDirection]?): IDBRequest[S, IDBCursorWithValue[S]]
14090+
IDBObjectStore[JC] def openKeyCursor(range: js.UndefOr[IDBKeyRange | IDBKey]?, direction: js.UndefOr[IDBCursorDirection]?): IDBRequest[S, IDBCursor[S]]
1409114091
IDBObjectStore[JC] def put(value: IDBValue, key: IDBKey?): IDBRequest[IDBObjectStore, IDBKey]
1409214092
IDBObjectStore[JC] def transaction: IDBTransaction
1409314093
IDBOpenDBRequest[JC] def addEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit
@@ -14126,8 +14126,8 @@ IDBStoreLike[JT] def getAllKeys(query: js.UndefOr[IDBKeyRange | IDBKey]?, count:
1412614126
IDBStoreLike[JT] def getKey(key: IDBKey): IDBRequest[S, js.UndefOr[IDBKey]]
1412714127
IDBStoreLike[JT] def keyPath: IDBKeyPath
1412814128
IDBStoreLike[JT] def name: String
14129-
IDBStoreLike[JT] def openCursor(range: js.UndefOr[IDBKeyRange | IDBKey]?, direction: js.UndefOr[IDBCursorDirection]?): IDBRequest[S, IDBCursor[S]]
14130-
IDBStoreLike[JT] def openKeyCursor(range: js.UndefOr[IDBKeyRange | IDBKey]?, direction: js.UndefOr[IDBCursorDirection]?): IDBRequest[S, IDBCursorReadOnly[S]]
14129+
IDBStoreLike[JT] def openCursor(range: js.UndefOr[IDBKeyRange | IDBKey]?, direction: js.UndefOr[IDBCursorDirection]?): IDBRequest[S, IDBCursorWithValue[S]]
14130+
IDBStoreLike[JT] def openKeyCursor(range: js.UndefOr[IDBKeyRange | IDBKey]?, direction: js.UndefOr[IDBCursorDirection]?): IDBRequest[S, IDBCursor[S]]
1413114131
IDBTransaction[JC] def abort(): Unit
1413214132
IDBTransaction[JC] def addEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit
1413314133
IDBTransaction[JC] def addEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit

‎api-reports/2_13.txt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14061,8 +14061,8 @@ IDBIndex[JC] def keyPath: IDBKeyPath
1406114061
IDBIndex[JC] val multiEntry: Boolean
1406214062
IDBIndex[JC] def name: String
1406314063
IDBIndex[JC] def objectStore: IDBObjectStore
14064-
IDBIndex[JC] def openCursor(range: js.UndefOr[IDBKeyRange | IDBKey]?, direction: js.UndefOr[IDBCursorDirection]?): IDBRequest[S, IDBCursor[S]]
14065-
IDBIndex[JC] def openKeyCursor(range: js.UndefOr[IDBKeyRange | IDBKey]?, direction: js.UndefOr[IDBCursorDirection]?): IDBRequest[S, IDBCursorReadOnly[S]]
14064+
IDBIndex[JC] def openCursor(range: js.UndefOr[IDBKeyRange | IDBKey]?, direction: js.UndefOr[IDBCursorDirection]?): IDBRequest[S, IDBCursorWithValue[S]]
14065+
IDBIndex[JC] def openKeyCursor(range: js.UndefOr[IDBKeyRange | IDBKey]?, direction: js.UndefOr[IDBCursorDirection]?): IDBRequest[S, IDBCursor[S]]
1406614066
IDBIndex[JC] def unique: Boolean
1406714067
IDBKeyRange[JC] def lower: IDBKey
1406814068
IDBKeyRange[JC] def lowerOpen: Boolean
@@ -14086,8 +14086,8 @@ IDBObjectStore[JC] def index(name: String): IDBIndex
1408614086
IDBObjectStore[JC] def indexNames: DOMStringList
1408714087
IDBObjectStore[JC] def keyPath: IDBKeyPath
1408814088
IDBObjectStore[JC] def name: String
14089-
IDBObjectStore[JC] def openCursor(range: js.UndefOr[IDBKeyRange | IDBKey]?, direction: js.UndefOr[IDBCursorDirection]?): IDBRequest[S, IDBCursor[S]]
14090-
IDBObjectStore[JC] def openKeyCursor(range: js.UndefOr[IDBKeyRange | IDBKey]?, direction: js.UndefOr[IDBCursorDirection]?): IDBRequest[S, IDBCursorReadOnly[S]]
14089+
IDBObjectStore[JC] def openCursor(range: js.UndefOr[IDBKeyRange | IDBKey]?, direction: js.UndefOr[IDBCursorDirection]?): IDBRequest[S, IDBCursorWithValue[S]]
14090+
IDBObjectStore[JC] def openKeyCursor(range: js.UndefOr[IDBKeyRange | IDBKey]?, direction: js.UndefOr[IDBCursorDirection]?): IDBRequest[S, IDBCursor[S]]
1409114091
IDBObjectStore[JC] def put(value: IDBValue, key: IDBKey?): IDBRequest[IDBObjectStore, IDBKey]
1409214092
IDBObjectStore[JC] def transaction: IDBTransaction
1409314093
IDBOpenDBRequest[JC] def addEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit
@@ -14126,8 +14126,8 @@ IDBStoreLike[JT] def getAllKeys(query: js.UndefOr[IDBKeyRange | IDBKey]?, count:
1412614126
IDBStoreLike[JT] def getKey(key: IDBKey): IDBRequest[S, js.UndefOr[IDBKey]]
1412714127
IDBStoreLike[JT] def keyPath: IDBKeyPath
1412814128
IDBStoreLike[JT] def name: String
14129-
IDBStoreLike[JT] def openCursor(range: js.UndefOr[IDBKeyRange | IDBKey]?, direction: js.UndefOr[IDBCursorDirection]?): IDBRequest[S, IDBCursor[S]]
14130-
IDBStoreLike[JT] def openKeyCursor(range: js.UndefOr[IDBKeyRange | IDBKey]?, direction: js.UndefOr[IDBCursorDirection]?): IDBRequest[S, IDBCursorReadOnly[S]]
14129+
IDBStoreLike[JT] def openCursor(range: js.UndefOr[IDBKeyRange | IDBKey]?, direction: js.UndefOr[IDBCursorDirection]?): IDBRequest[S, IDBCursorWithValue[S]]
14130+
IDBStoreLike[JT] def openKeyCursor(range: js.UndefOr[IDBKeyRange | IDBKey]?, direction: js.UndefOr[IDBCursorDirection]?): IDBRequest[S, IDBCursor[S]]
1413114131
IDBTransaction[JC] def abort(): Unit
1413214132
IDBTransaction[JC] def addEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], options: EventListenerOptions): Unit
1413314133
IDBTransaction[JC] def addEventListener[T <: Event](`type`: String, listener: js.Function1[T, _], useCapture: Boolean?): Unit

‎dom/src/main/scala/org/scalajs/dom/IDBStoreLike.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,13 +83,13 @@ trait IDBStoreLike[S] extends js.Object {
8383
* [[IDBRequest]] with the `target` value being a new cursor or `null`.
8484
*/
8585
def openCursor(range: js.UndefOr[IDBKeyRange | IDBKey] = js.native,
86-
direction: js.UndefOr[IDBCursorDirection] = js.native): IDBRequest[S, IDBCursor[S]] = js.native
86+
direction: js.UndefOr[IDBCursorDirection] = js.native): IDBRequest[S, IDBCursorWithValue[S]] = js.native
8787

8888
/** The method sets the position of the cursor to the appropriate key, based on the specified direction.
8989
*
9090
* @return
9191
* [[IDBRequest]] with the `target` value being a new cursor or `null`.
9292
*/
9393
def openKeyCursor(range: js.UndefOr[IDBKeyRange | IDBKey] = js.native,
94-
direction: js.UndefOr[IDBCursorDirection] = js.native): IDBRequest[S, IDBCursorReadOnly[S]] = js.native
94+
direction: js.UndefOr[IDBCursorDirection] = js.native): IDBRequest[S, IDBCursor[S]] = js.native
9595
}

0 commit comments

Comments
 (0)