Skip to content

Commit 3bb40a8

Browse files
authored
Merge pull request #773 from scala-js/fix/websocket-onerror
Fix `WebSocket#onerror`
2 parents 228518c + ddeab4d commit 3bb40a8

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

api-reports/2_12.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -26693,7 +26693,7 @@ WebSocket[JC] def close(code: Int?, reason: String?): Unit
2669326693
WebSocket[JC] def dispatchEvent(evt: Event): Boolean
2669426694
WebSocket[JC] def extensions: String
2669526695
WebSocket[JC] var onclose: js.Function1[CloseEvent, _]
26696-
WebSocket[JC] var onerror: js.Function1[ErrorEvent, _]
26696+
WebSocket[JC] var onerror: js.Function1[Error, _]
2669726697
WebSocket[JC] var onmessage: js.Function1[MessageEvent, _]
2669826698
WebSocket[JC] var onopen: js.Function1[Event, _]
2669926699
WebSocket[JC] def readyState: Int

api-reports/2_13.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -26693,7 +26693,7 @@ WebSocket[JC] def close(code: Int?, reason: String?): Unit
2669326693
WebSocket[JC] def dispatchEvent(evt: Event): Boolean
2669426694
WebSocket[JC] def extensions: String
2669526695
WebSocket[JC] var onclose: js.Function1[CloseEvent, _]
26696-
WebSocket[JC] var onerror: js.Function1[ErrorEvent, _]
26696+
WebSocket[JC] var onerror: js.Function1[Error, _]
2669726697
WebSocket[JC] var onmessage: js.Function1[MessageEvent, _]
2669826698
WebSocket[JC] var onopen: js.Function1[Event, _]
2669926699
WebSocket[JC] def readyState: Int

dom/src/main/scala/org/scalajs/dom/WebSocket.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ class WebSocket(var url: String = js.native, var protocol: String = js.native) e
5454
var onclose: js.Function1[CloseEvent, _] = js.native
5555

5656
/** An event listener to be called when an error occurs. This is a simple event named "error". */
57-
var onerror: js.Function1[ErrorEvent, _] = js.native
57+
var onerror: js.Function1[Error, _] = js.native
5858

5959
/** A string indicating the type of binary data being transmitted by the connection. This should be either "blob" if
6060
* DOM Blob objects are being used or "arraybuffer" if ArrayBuffer objects are being used.

0 commit comments

Comments
 (0)