Make it possible to build npm with a linked language repo #2214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes several changes: * It renames the `UPDATE_SASS_PROTOCOL` environment variable used by the Grinder `protobuf` task to `UPDATE_SASS_SASS_REPO` to make it more generic and so usable by other tasks. The previous name still works but is considered deprecated. * The `pkg-npm-*` grinder tasks now respects the `UPDATE_SASS_SASS_REPO` environment variable. This allows repos to ensure that the linked language repo's version of the TypeScript types are used when building the npm package. * `UPDATE_SASS_SASS_REPO=false` is set for all the `pkg-npm-*` tasks run by this repo, so that they will use the linked language repo's version of the TypeScript types.
nex3
force-pushed
the
npm-linked-language
branch
from
88ade5d to
99aeb08
Compare
nex3
added a commit
to sass/sass-spec
that referenced
this pull request
Apr 9, 2024
This was referenced Apr 9, 2024
nex3
added a commit
to sass/sass-site
that referenced
this pull request
Apr 9, 2024
Goodwine
reviewed
Apr 10, 2024
Goodwine
approved these changes
Apr 10, 2024
Co-authored-by: Carlos (Goodwine) <[email protected]>
nex3
added a commit
to sass/sass-spec
that referenced
this pull request
Apr 11, 2024
nex3
added a commit
to sass/sass-site
that referenced
this pull request
Apr 11, 2024
This was referenced Jun 3, 2024
zvizvi
pushed a commit
to zvizvi/sass-site
that referenced
this pull request
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes several changes:
It renames the
UPDATE_SASS_PROTOCOLenvironment variable used bythe Grinder
protobuftask toUPDATE_SASS_SASS_REPOto make itmore generic and so usable by other tasks. The previous name still
works but is considered deprecated.
The
pkg-npm-*grinder tasks now respects theUPDATE_SASS_SASS_REPOenvironment variable. This allows repos toensure that the linked language repo's version of the TypeScript
types are used when building the npm package.
UPDATE_SASS_SASS_REPO=falseis set for all thepkg-npm-*tasksrun by this repo, so that they will use the linked language repo's
version of the TypeScript types.