format conditional expression based on microsoft#4757

Author: saschanaz

src/services/formatting/smartIndenter.ts

@@ -463,7 +463,6 @@ namespace ts.formatting {
                 case SyntaxKind.VariableDeclaration:
                 case SyntaxKind.ExportAssignment:
                 case SyntaxKind.ReturnStatement:
-                case SyntaxKind.ConditionalExpression:
                 case SyntaxKind.ArrayBindingPattern:
                 case SyntaxKind.ObjectBindingPattern:
                 case SyntaxKind.JsxOpeningElement:
@@ -512,6 +511,8 @@ namespace ts.formatting {
                         ((<ImportClause>child).namedBindings && (<ImportClause>child).namedBindings.kind !== SyntaxKind.NamedImports);
                 case SyntaxKind.JsxElement:
                     return childKind !== SyntaxKind.JsxClosingElement;
+                case SyntaxKind.ConditionalExpression:
+                    return (parent as ConditionalExpression).whenFalse !== child;
             }
             // No explicit rule for given nodes so the result will follow the default value argument
             return indentByDefault;

tests/cases/fourslash/formatConditionalExpressions.ts

@@ -0,0 +1,18 @@
+/// <reference path="fourslash.ts"/>
+
+////let v =
+////    0 ? 1 :
+////    //
+/////*falseBranchExpression*/    2 ? 3 :
+/////*indent*/
+////    //
+/////*falseBranchToken*/    2;
+
+format.document();
+
+goTo.marker("falseBranchExpression");
+verify.currentLineContentIs("    2 ? 3 :");
+goTo.marker("indent");
+verify.indentationIs(8);
+goTo.marker("falseBranchToken");
+verify.currentLineContentIs("    2;");