fix: handle case-insensitive path conflicts in groupTargetsByDirectoryTree (#164)

Author: sapphi-red

.changeset/seven-things-marry.md

@@ -0,0 +1,5 @@
+---
+'vite-plugin-static-copy': patch
+---
+
+fixes case-insensitive path conflicts causing copy failures (EEXIST error)

src/utils.bench.ts

@@ -0,0 +1,104 @@
+import { bench, describe } from 'vitest'
+import { groupTargetsByDirectoryTree } from './utils'
+
+type TestTarget = {
+  resolvedDest: string
+  id: string
+}
+
+function generateTestTargets(count: number): TestTarget[] {
+  const targets: TestTarget[] = []
+  const basePaths = [
+    '/home/user/project/dist',
+    '/home/user/project/dist/assets',
+    '/home/user/project/dist/assets/images',
+    '/home/user/project/dist/assets/css',
+    '/home/user/project/dist/components',
+    '/home/user/project/dist/components/ui',
+    '/home/user/project/dist/pages',
+    '/home/user/project/public',
+    '/home/user/project/public/static',
+    '/tmp/build'
+  ]
+
+  for (let i = 0; i < count; i++) {
+    const basePath = basePaths[i % basePaths.length]
+    const suffix = Math.floor(i / basePaths.length)
+    targets.push({
+      resolvedDest:
+        suffix > 0 ? `${basePath}/file${suffix}` : `${basePath}/file`,
+      id: `target-${i}`
+    })
+  }
+
+  return targets
+}
+
+describe('groupTargetsByDirectoryTree benchmark', () => {
+  bench('small dataset (10 targets)', () => {
+    const targets = generateTestTargets(10)
+    groupTargetsByDirectoryTree(targets)
+  })
+
+  bench('medium dataset (100 targets)', () => {
+    const targets = generateTestTargets(100)
+    groupTargetsByDirectoryTree(targets)
+  })
+
+  bench('large dataset (1000 targets)', () => {
+    const targets = generateTestTargets(1000)
+    groupTargetsByDirectoryTree(targets)
+  })
+
+  bench('nested directory structure (deep)', () => {
+    const targets: TestTarget[] = []
+    const baseDepth = 10
+
+    for (let depth = 0; depth < baseDepth; depth++) {
+      const pathParts = ['/home', 'user', 'project']
+      for (let i = 0; i <= depth; i++) {
+        pathParts.push(`level${i}`)
+      }
+      targets.push({
+        resolvedDest: pathParts.join('/'),
+        id: `nested-${depth}`
+      })
+    }
+
+    groupTargetsByDirectoryTree(targets)
+  })
+
+  bench('mixed path scenarios', () => {
+    const targets: TestTarget[] = [
+      { resolvedDest: '/home/user/project/dist/index.html', id: 'html1' },
+      { resolvedDest: '/home/user/project/dist/main.js', id: 'js1' },
+      { resolvedDest: '/home/user/project/dist/style.css', id: 'css1' },
+
+      { resolvedDest: '/home/user/project/dist', id: 'parent' },
+      { resolvedDest: '/home/user/project/dist/assets', id: 'child1' },
+      {
+        resolvedDest: '/home/user/project/dist/assets/images',
+        id: 'grandchild1'
+      },
+
+      { resolvedDest: '/tmp/build/output.txt', id: 'independent1' },
+      { resolvedDest: '/var/backup/files/data.json', id: 'independent2' },
+
+      { resolvedDest: '/home/user/Project/Dist/File.txt', id: 'case1' },
+      { resolvedDest: '/home/user/project/dist/file.txt', id: 'case2' }
+    ]
+
+    groupTargetsByDirectoryTree(targets)
+  })
+
+  bench('duplicate paths', () => {
+    const targets: TestTarget[] = []
+    for (let i = 0; i < 50; i++) {
+      targets.push({
+        resolvedDest: '/home/user/project/dist/output',
+        id: `duplicate-${i}`
+      })
+    }
+    groupTargetsByDirectoryTree(targets)
+  })
+})

src/utils.test.ts

@@ -20,6 +20,11 @@ describe('isSubdirectoryOrEqual', () => {
     ['../', './', false],
     ['../test', './', false],
     ['../test/', './', false],
+    // case-insensitive
+    ['./foo/bar', './FOO/BAR', true],
+    ['./FOO/BAR', './foo/bar', true],
+    ['./foo/bar', './foo/BAR', true],
+    ['./foo/bar', './foo/baz', false],
     ...(isWindows
       ? ([
           ['C:/', 'C:/', true],
@@ -54,7 +59,8 @@ describe('groupTargetsByDirectoryTree', () => {
     defineCase(['a', 'a/b/c'], [['a', 'a/b/c']]),
     defineCase(['a/b', 'a/b/c'], [['a/b', 'a/b/c']]),
     defineCase(['a/b/c', 'a/b'], [['a/b/c', 'a/b']]),
-    defineCase(['a', 'a/b/d'], [['a', 'a/b/d']])
+    defineCase(['a', 'a/b/d'], [['a', 'a/b/d']]),
+    defineCase(['foo/bar', 'FOO/BAR'], [['foo/bar', 'FOO/BAR']])
   ] satisfies {
     name: string
     input: { resolvedDest: string }[]

src/utils.ts

@@ -30,11 +30,18 @@ type ResolvedTarget = SimpleTarget & {
 /**
  * Whether a is a subdirectory of b or equal to b
  *
+ * Note: Uses case-insensitive comparison regardless of filesystem behavior
+ *
  * @param a absolute path
  * @param b absolute path
  */
 export const isSubdirectoryOrEqual = (a: string, b: string) => {
-  return a.startsWith(b + path.sep) || a === b
+  const normalizedA = a.toLowerCase()
+  const normalizedB = b.toLowerCase()
+  return (
+    normalizedA.startsWith(normalizedB + path.sep) ||
+    normalizedA === normalizedB
+  )
 }
 
 export const groupTargetsByDirectoryTree = <T extends { resolvedDest: string }>(
@@ -52,7 +59,7 @@ export const groupTargetsByDirectoryTree = <T extends { resolvedDest: string }>(
 
   const groups: Record<string, (T & { order: number })[]> = {}
   for (const target of targetsWithOrder) {
-    const { resolvedDest } = target
+    const resolvedDest = target.resolvedDest.toLowerCase()
     const parent = Object.keys(groups).find(key =>
       isSubdirectoryOrEqual(key, resolvedDest)
     )

test/fixtures/eexist/a/1.txt

@@ -0,0 +1 @@
+foo1

test/fixtures/eexist/b/1.txt

@@ -0,0 +1 @@
+foo1

test/fixtures/vite.config.ts

@@ -135,7 +135,9 @@ export default defineConfig({
           rename: filename => {
             return `${filename}.foo`
           }
-        }
+        },
+        { src: 'eexist/*', dest: 'eexist' },
+        { src: 'eexist/*', dest: 'Eexist' }
       ]
     })
   ]

test/testcases.ts

@@ -135,6 +135,16 @@ export const testcases: Record<string, Testcase[]> = {
       src: 'foo.txt',
       dest: '/fixture12/foo.foo',
       contentType: ''
+    },
+    {
+      name: 'parallel copy to same dir (1)',
+      src: './eexist/a/1.txt',
+      dest: '/eexist/a/1.txt'
+    },
+    {
+      name: 'parallel copy to same dir (2)',
+      src: './eexist/b/1.txt',
+      dest: '/eexist/b/1.txt'
     }
   ],
   'vite.absolute.config.ts': [