Skip to content

Remove node version from published package #1175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
interactivellama opened this issue Nov 15, 2017 · 1 comment
Closed

Remove node version from published package #1175

interactivellama opened this issue Nov 15, 2017 · 1 comment

Comments

@interactivellama
Copy link
Contributor

interactivellama commented Nov 15, 2017

This is a client side UI library, not a node library. Distributed package tags should not have a node limitation. Dev environment should however just for consistency.

I suggest:

"devEngines": {
    "node": "4.x || 5.x || 6.x || 7.x || 8.x",
    "npm": "2.x || 3.x || 4.x || 5.x"
  },

and that be removed on package/tag build. This will mean no node version demands for NPM/tag package.

Although we may want a <.10 for CJS. I will look into this when #1146 is worked on.

Nevermind devEngines is a yarn spec. We could just leave it up to the devDependencies to scream if they need a node version.

Background on why it's 6.x. #1011 It's related to a CI fail with Node 8.x

@interactivellama interactivellama changed the title Switch to devEngines Remove node version from published package Nov 15, 2017
@interactivellama
Copy link
Contributor Author

Fixed by #1176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant