Skip to content

Reviewer guide: Link to Eric Gourgoulhon's test notebook #38503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Reviewer guide: Link to Eric Gourgoulhon's test notebook #38503

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/doc/en/developer/review.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,13 @@ The following should generally be checked while reading and testing the code:
optional doctests related to the functionality. See :ref:`chapter-doctesting`
for more information.

For changes that affect the **user interface**, in particular, upgrades to
IPython and Jupyter component packages, manual testing is crucial because
our automatic tests do not cover the user interface. We recommend to use
a `Jupyter notebook with comprehensive tests of graphics and typesetting
<https://github.com/egourgoulhon/SageMathTest/blob/master/Notebooks/test_display.ipynb>`_,
some of which is Sage-specific.

You are now ready to change the PR's status (see
:ref:`section-github-pr-status`):

Expand Down