notebook -- removed unused NotebookSettings and UserSetting related code

[TimothyClemans]

Depends on #4089

CC: @wjp

Component: notebook

Work Issues: should be closed

Issue created by migration from https://trac.sagemath.org/ticket/4550

[williamstein]

comment:2

Attachment: trac_4550.patch.gz

Just out of curiosity, what is the justification for removing this code, besides "it currently isn't being used"? For example, did you (Timothy) write new settings code that will replace this? I think maybe (?) I wrote this code a long time ago as the framework that user and notebook settings code would go into, but never flushed that out. So unless there is no code that is going to replace or some new design or something, I would like some sort of explanation about what the point of this is.

[TimothyClemans]

comment:3

I implemented Notebook and User settings without using the pre-existing framework. User Settings is already in Sage and Notebook Settings is #4551

[TimothyClemans]

Attachment: sage-4550.patch.gz

[TimothyClemans]

comment:4

apply sage-4550.patch (rebased)

[dandrake]

Attachment: trac_4550-2.patch.gz

rebased on 4.1.2.alpha0

[dandrake]

comment:6

I'm going to try and go through this group of notebook patches and rebase them so we can at least discuss them.

[qed777]

comment:7

See #4551 for a sagenb (cf. #6983) rebase that includes attachment: trac_4550-2.patch.

[qed777]

Work Issues: should be closed

[qed777]

comment:8

#4551 subsumes this ticket. Please close this one.