loading a file with spaces in the filename doesn't work

[sagetrac-anakha]

try it at home:

$ echo 'print "ok"' > 'test file.sage'
$ sage "test file.sage"

Component: misc

Issue created by migration from https://trac.sagemath.org/ticket/4354

[sagetrac-anakha]

comment:1

Crap, I need to relax on the submit button

[sagetrac-anakha]

comment:2

Attachment: trac_4354.patch.gz

With the above patch and replacement sage script the example given should work and print 'ok'.

Be aware that if you copied the sage script somewhere (like /usr/local/bin) for convenience you need to modify that copy too. The line near the end that reads

"$SAGE_ROOT/local/bin/sage-sage" $*

needs to be replaced by

"$SAGE_ROOT/local/bin/sage-sage" "$@"

[sagetrac-mvngu]

comment:3

For the patch sage, below are some possible fixes to the documentation. Please also refer to #1389.

-echo "You must compile SAGE first using 'make' in the SAGE root directory." >&2
+echo "You must compile Sage first using 'make' in the Sage root directory." >&2

-echo "(If you have already compiled SAGE, you must set the SAGE_ROOT variable in "
+echo "(If you have already compiled Sage, you must set the SAGE_ROOT variable in "

-# whenver SAGE exists.
+# whenever Sage exits.

[williamstein]

comment:4

REFEREE:

Can you please rebase this against 3.2.1.alpha*? I tried applying and got some many failed hunks I can't go further.

sage: hg_scripts.apply('https://github.com/sagemath/sage-prod/files/10642334/trac_4354.patch.gz')
Attempting to load remote file: https://github.com/sagemath/sage/files/ticket4354/trac_4354.patch.gz?format=raw
Loading: [..]
cd "/Users/wstein/sage/local/bin" && hg status
cd "/Users/wstein/sage/local/bin" && hg status
cd "/Users/wstein/sage/local/bin" && hg import   "/Users/wstein/.sage/temp/teragon_2.local/1537/tmp_0.patch"
applying /Users/wstein/.sage/temp/teragon_2.local/1537/tmp_0.patch
patching file sage-sage
Hunk #5 succeeded at 227 with fuzz 1 (offset 4 lines).
Hunk #6 succeeded at 246 with fuzz 1 (offset 4 lines).
Hunk #7 FAILED at 332
Hunk #8 FAILED at 376
Hunk #10 succeeded at 474 with fuzz 1 (offset 41 lines).
Hunk #12 succeeded at 507 with fuzz 1 (offset 41 lines).
Hunk #18 succeeded at 603 with fuzz 1 (offset 41 lines).
Hunk #20 succeeded at 647 with fuzz 1 (offset 41 lines).
Hunk #27 FAILED at 768
Hunk #28 FAILED at 794
4 out of 28 hunks FAILED -- saving rejects to file sage-sage.rej
abort: patch failed to apply

Note -- I did read the patch and I think it's very good. Also, I'm very glad for Mvngu's observations about all those typos, especially line -2 of SAGE_ROOT/sage. Can you fix those typos in sage too?

[williamstein]

comment:5

From patch author:

I'm kind of overloaded with work from school now, so it will have to
wait about 2 or 3 weeks.  If nobody does it before then, I'll do it.

[sagetrac-abergeron]

Attachment: sage.2.gz