Skip to content

fix focus wrong field #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix focus wrong field #828

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/number_format_base.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,9 @@ export default function NumberFormatBase<BaseType = InputAttributes>(

useIsomorphicLayoutEffect(() => {
const input = focusedElm.current;
if (formattedValue !== lastUpdatedValue.current.formattedValue && input) {
const activeElement = document.activeElement;

if (input === activeElement && formattedValue !== lastUpdatedValue.current.formattedValue && input) {
Copy link
Owner

@s-yadav s-yadav May 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Humm, @kasperdun can you share an example where this is breaking? Basically focusedElm.current is set only when that input is focused. As we set the focusedElm.current to undefined when a blur is called.

const caretPos = getNewCaretPosition(
lastUpdatedValue.current.formattedValue,
formattedValue,
Expand Down