-
-
Notifications
You must be signed in to change notification settings - Fork 12
feat(video): create Video component #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
ec63dde
fix: update timeIndicator subcomponent
kaseyvee 11e3069
refactor: update controls to work with video
kaseyvee 24a653a
refactor: update media types
kaseyvee 5f5a820
feat(video): create video component
kaseyvee f36bfc9
docs(video): add video stories
kaseyvee 746cbb5
test(video): add video tests
kaseyvee 00d2c63
refactor: update captions toggle and create generic toggle interface
kaseyvee cd42d3a
refactor: separate controls into different files
kaseyvee f2ebb3c
fix: update mobile view
kaseyvee 8c10bfd
refactor: update fullscreen button function and update tests
kaseyvee f2415ee
feat: allow ability to view transript on fullscreen
kaseyvee bacba73
fix: update based on colour suggestion
kaseyvee 2dd7274
refactor: add suggestions
kaseyvee c9cca0b
fix: add missing poster props and add back background
kaseyvee 64e3230
docs(video): add story with poster prop
kaseyvee 01d3fc2
fix: remove captions toggle component
kaseyvee 361bcb2
test: update tests
kaseyvee 2905cd0
fix: add video to exports
kaseyvee 7461857
fix: visual bug when showing short transcripts on fullscreen
kaseyvee 813a4be
fix: add background colour to controls
kaseyvee 7d97130
fix: bug when entering fullscreen on mobile
kaseyvee fc6e818
refactor: replace missed backgroundColor with variable
kaseyvee 37c9891
refactor: move video folder to media
kaseyvee 69efd6c
fix: bug when switching between viewport sizes on fullscreen
kaseyvee edfa4d7
test: update tests
kaseyvee ac60180
ci: make cypress run with chrome
kaseyvee b52deca
docs: add video in quickstart example
kaseyvee 5739f4b
refactor: move youtube back to original folder
kaseyvee c493dfa
refactor: add suggestions for handleVolumeChange
kaseyvee 1afd19a
docs: add comments for event listeners
kaseyvee 93dbc3e
test: update mediaIconButton test attributes
kaseyvee a5fa502
fix: add transcript and promise handling suggestions
kaseyvee b76f3b1
test: add test for fullscreen error
kaseyvee c985ed3
fix: add suggestions
kaseyvee e7fb9d7
fix: update variable names and show error descriptions
kaseyvee acb808b
feat: hide controls on mouse inactivity
kaseyvee 608682a
feat: handle keyboard user inactivity
kaseyvee 1bcfbb9
Apply suggestions from code review
kaseyvee e4c917d
docs: make captions story have smaller dimensions
kaseyvee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,3 +25,4 @@ jobs: | |
| uses: cypress-io/github-action@v6 | ||
| with: | ||
| component: true | ||
| browser: chrome | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,6 +3,7 @@ | |
| gap: 24px; | ||
| align-items: center; | ||
| position: relative; | ||
| width: 100%; | ||
| } | ||
|
|
||
| .rustic-progress-slider { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.