-
-
Notifications
You must be signed in to change notification settings - Fork 12
fix: customize vegalite menu #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| ) | ||
| .then((url) => { | ||
| menuItems[index].href = url | ||
| menuItems[index].downloadFileName = fileName |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| menuItems[index].downloadFileName = fileName | |
| menuItems[index].downloadFileName = `${fileName}.${ext}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is not needed. Depending on the file type, .svg and .png will be added automatically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its better to mention the type. I see no harm in doing so
|
@lyjeileen are you setting the width of the popover somewhere ? From your screenshots and video, it appears to be too wide, i.e., wider than the content. |
I mentioned this in my PR description. PopoverMenu set |
Change
Maybe we could consider reduce the min-width of the PopoverMenu component in a follow-up? It looks too wide for the options in Vega-Lite and I couldn't overwrite it because when it's being rendered, it doesn't have any parent container.
Screenshots
Before
After
Video