Skip to content

multiboot2-header: various improvements #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
phip1611 opened this issue May 3, 2023 · 2 comments · Fixed by #142
Closed

multiboot2-header: various improvements #135

phip1611 opened this issue May 3, 2023 · 2 comments · Fixed by #142
Assignees
@phip1611

Comments

@phip1611
Copy link
Member

phip1611 commented May 3, 2023 •
edited
Loading

@phip1611 phip1611 self-assigned this May 3, 2023
@phip1611 phip1611 mentioned this issue May 6, 2023
Merged
@phip1611 phip1611 changed the title multiboot2-header: rename std module to alloc multiboot2-header: various improvements May 15, 2023
@YtvwlD
Copy link
Contributor

YtvwlD commented May 15, 2023

Yeah, I'm not sure about the byte slice. This can be useful to be able to discard the rest of the file.

@phip1611
Copy link
Member Author

phip1611 commented May 15, 2023 •
edited
Loading

It's okay, I can think about it and work on it eventually. This is probably technical debt that wasn't introduced by you

@phip1611 phip1611 linked a pull request Jun 20, 2023 that will close this issue
multiboot2: load: remove odd offset thingy #142
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phip1611 phip1611

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

multiboot2: load: remove odd offset thingy rust-osdev/multiboot2
2 participants
@YtvwlD @phip1611