Create T-all zulip user group

[jieyouxu]

This is needed to configure the infra announcement channel so the zulip user group membership is synced automatically with project team membership.

This notably does not include working groups, project groups, or marker teams.

See #t-infra > Communication method for dev desktops @ 💬 for more details.

[Kobzol]

I would perhaps rather have an (either implicit or explicit) opt-out of the Zulip ID check for t-all specifically. Otherwise every new team member added without a Zulip ID will trigger the Zulip check on this team. That being said, if we wanted to make Zulip membership "more mandatory", then that would actually be nice.

[traviscross]

That being said, if we wanted to make Zulip membership "more mandatory", then that would actually be nice.

We have recently been moving things that weren't on Zulip to Zulip. I wonder if maybe we are at or near the point we could do this.

[Kobzol]

I don't know if everyone in team is actively on Zulip (most likely not), and we still didn't resolve the wg-embedded situation, which is an organization that is currently in team, and we kind of manage their GitHub repos, but they are completely separate and operate mostly on Matrix.

But at least from a technical point of view, I think that requiring people in team to have an associated Zulip handle (even if they don't actually actively use Zulip) would not be such a problem, especially since it's quite easy to create a Zulip account using a GitHub account, which we already require for everyone. So we could say that to be in the Project, you must have GitHub + Zulip (while now it's just GitHub).

[jieyouxu]

I would perhaps rather have an (either implicit or explicit) opt-out of the Zulip ID check for t-all specifically. Otherwise every new team member added without a Zulip ID will trigger the Zulip check on this team. That being said, if we wanted to make Zulip membership "more mandatory", then that would actually be nice.

Okay, that sounds reasonable. Though I think that change will need to land after #1977.

Requiring everyone to have a zulip-id seems reasonable as well, though I'd defer that decision to the council. For this purpose, we can just use the T-all-won't-hard-require-everyone-to-have-zulip-id I suppose. Do you think we should nominate this for the council, or should we just go with T-all-is-special for now?

[jieyouxu]

Remaining:

[ERROR rust_team::validate] validation error: person `U007D` in 'all' is a member of a Zulip user group 'T-all' but has no Zulip id
[ERROR rust_team::validate] validation error: person `andrewpollack` in 'all' is a member of a Zulip user group 'T-all' but has no Zulip id
[ERROR rust_team::validate] validation error: person `arshiamufti` in 'all' is a member of a Zulip user group 'T-all' but has no Zulip id
[ERROR rust_team::validate] validation error: person `bnchi` in 'all' is a member of a Zulip user group 'T-all' but has no Zulip id
[ERROR rust_team::validate] validation error: person `celaus` in 'all' is a member of a Zulip user group 'T-all' but has no Zulip id
[ERROR rust_team::validate] validation error: person `opeolluwa` in 'all' is a member of a Zulip user group 'T-all' but has no Zulip id
[ERROR rust_team] 6 validation errors found

[Kobzol]

We could just put these people into the ignore list for now (I added that concept in #2040).

[jieyouxu]

Yeah, that's my plan, just ran out of time yesterday.

[github-actions]

Dry-run check results

[WARN  sync_team] sync-team is running in dry mode, no changes will be applied.
[INFO  sync_team] synchronizing github

[jieyouxu]

Council FCP on rust-lang/leadership-council#228 has completed, so no longer blocked.

[jieyouxu]

We could just put these people into the ignore list for now (I added that concept in #2040).

I'm using excluded-people for now, didn't want to pull those changes into this PR.

[marcoieni]

what does "grandfathering" mean in this context? Can you explain this in simpler terms in the comment

[jieyouxu]

Previously there was no T-all Zulip group, and we didn't require all project team members to have a Zulip ID in their people/ entry prior to rust-lang/leadership-council#228. I clarified this in the comment.

[marcoieni]

I approved this but later realized that probably this needs more a team repo admin to approve?

[jieyouxu]

Hm, probably. I'll wait for another team-repo-admin to review.