Deny all warnings and fix errors (#135)

* [travis-ci] deny warnings

* fix all warnings

Author: gnzlbg

Cargo.toml

@@ -21,3 +21,6 @@ opt-level = 3
 [dev-dependencies]
 stdsimd-test = { path = "stdsimd-test" }
 cupid = "0.3"
+
+[features]
+strict = []

ci/run.sh

@@ -17,5 +17,5 @@ esac
 
 echo "RUSTFLAGS=${RUSTFLAGS}"
 
-cargo test --target $TARGET
-cargo test --release --target $TARGET
+cargo test --target $TARGET --features "strict"
+cargo test --release --target $TARGET --features "strict"

examples/nbody.rs

@@ -1,12 +1,10 @@
+#![cfg_attr(feature = "strict", deny(warnings))]
 #![feature(cfg_target_feature)]
 #![feature(target_feature)]
 
 extern crate stdsimd;
-
 use self::stdsimd::simd;
-use self::stdsimd::vendor;
-
-use simd::{f64x2, f32x4};
+use simd::f64x2;
 
 const PI: f64 = 3.141592653589793;
 const SOLAR_MASS: f64 = 4.0 * PI * PI;
@@ -18,31 +16,35 @@ pub trait Frsqrt {
 
 impl Frsqrt for f64x2 {
     fn frsqrt(&self) -> Self {
-        unsafe {
-            #[cfg(all(any(target_arch = "x86", target_arch = "x86_64"),
-                      target_feature = "sse"))]
-            {
-                let t = self.as_f32x2();
-                let u = vendor::_mm_rsqrt_ps(
-                    f32x4::new(t.extract(0), t.extract(1), 0., 0.)).as_f64x4();
-                f64x2::new(u.extract(0), u.extract(1))
-            }
-            #[cfg(all(any(target_arch = "arm", target_arch = "aarch64"),
-                      target_feature = "neon"))]
-            {
-                vendor::vrsqrte_f32(self.as_f32x2()).as_f64x2()
-            }
-
-            #[cfg(not(any(all(any(target_arch = "x86", target_arch = "x86_64"),
-                              target_feature = "sse"),
-                          all(any(target_arch = "arm", target_arch = "aarch64"),
-                              target_feature = "neon")
-            )))]
-            {
-                self.replace(0, 1. / self.extract(0).sqrt());
-                self.replace(1, 1. / self.extract(1).sqrt());
-                *self
-            }
+        #[cfg(all(any(target_arch = "x86", target_arch = "x86_64"),
+                  target_feature = "sse"))]
+        {
+            use self::stdsimd::vendor;
+            use simd::f32x4;
+
+            let t = self.as_f32x2();
+
+            let u = unsafe {
+                vendor::_mm_rsqrt_ps(
+                    f32x4::new(t.extract(0), t.extract(1), 0., 0.)).as_f64x4()
+            };
+            f64x2::new(u.extract(0), u.extract(1))
+        }
+        #[cfg(all(any(target_arch = "arm", target_arch = "aarch64"),
+                  target_feature = "neon"))]
+        {
+            use self::stdsimd::vendor;
+            unsafe { vendor::vrsqrte_f32(self.as_f32x2()).as_f64x2() }
+        }
+        #[cfg(not(any(all(any(target_arch = "x86", target_arch = "x86_64"),
+                          target_feature = "sse"),
+                      all(any(target_arch = "arm", target_arch = "aarch64"),
+                          target_feature = "neon")
+        )))]
+        {
+            self.replace(0, 1. / self.extract(0).sqrt());
+            self.replace(1, 1. / self.extract(1).sqrt());
+            *self
         }
     }
 }

examples/play.rs

@@ -1,3 +1,4 @@
+#![cfg_attr(feature = "strict", deny(warnings))]
 #![feature(target_feature)]
 
 #[cfg(any(target_arch = "x86", target_arch = "x86_64"))]

examples/types.rs

@@ -1,3 +1,4 @@
+#![cfg_attr(feature = "strict", deny(warnings))]
 #![feature(target_feature)]
 
 #[cfg(any(target_arch = "x86", target_arch = "x86_64"))]

examples/wat.rs

@@ -1,3 +1,4 @@
+#![cfg_attr(feature = "strict", deny(warnings))]
 #![feature(target_feature)]
 
 #[cfg(any(target_arch = "x86", target_arch = "x86_64"))]

src/arm/neon.rs

@@ -23,8 +23,6 @@ pub unsafe fn vrsqrte_f32(a: f32x2) -> f32x2 {
 
 #[cfg(test)]
 mod tests {
-    use stdsimd_test::simd_test;
-
     use v64::{f32x2};
     use arm::neon;
 

src/arm/v6.rs

@@ -22,8 +22,6 @@ pub unsafe fn _rev_u32(x: u32) -> u32 {
 
 #[cfg(test)]
 mod tests {
-    use stdsimd_test::simd_test;
-
     use arm::v6;
 
     #[test]

src/arm/v7.rs

@@ -46,8 +46,6 @@ extern "C" {
 
 #[cfg(test)]
 mod tests {
-    use stdsimd_test::simd_test;
-
     use arm::v7;
 
     #[test]

src/arm/v8.rs

@@ -56,8 +56,6 @@ pub unsafe fn _cls_u64(x: u64) -> u64 {
 
 #[cfg(test)]
 mod tests {
-    use stdsimd_test::simd_test;
-
     use arm::v8;
 
     #[test]

src/lib.rs

@@ -109,6 +109,7 @@
 //!
 //! [vendor]: https://github.com/rust-lang-nursery/stdsimd/issues/40
 
+#![cfg_attr(feature = "strict", deny(warnings))]
 #![allow(dead_code)]
 #![allow(unused_features)]
 #![feature(

tests/cpu-detection.rs

@@ -1,6 +1,8 @@
+#![cfg_attr(feature = "strict", deny(warnings))]
 #![feature(cfg_target_feature)]
 
 #[macro_use]
+#[cfg(any(target_arch = "x86", target_arch = "x86_64"))]
 extern crate stdsimd;
 extern crate cupid;