Skip to content

Complete, or spurious .partial file can cause repeated failure to download #1854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kinnison opened this issue May 16, 2019 · 1 comment
Closed
Labels

Comments

@kinnison
Copy link
Contributor

If a .partial file is actually complete, then any attempt to continue the download will fail because the byte-range request will be out-of-range. There is then no recovery method within rustup instead the user ends up having to delete the .partial file and try again.

In #1243 this has been discussed, and there's at least one person for whom the partial file was corrupt, and one for whom it was complete, so we need to handle both of those cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants