Run shellcheck only in Travis Linux

Author: tesuji

.travis.yml

@@ -1,4 +1,3 @@
-sudo: required
 dist: trusty
 services:
   - docker
@@ -51,11 +50,11 @@ matrix:
       env: MACOSX_DEPLOYMENT_TARGET=10.7 TARGET=x86_64-apple-darwin NO_ADD=1
 
 install:
-  - if [ -z "$NO_ADD" ]; then rustup target add $TARGET; fi
+  - if [ -z "$NO_ADD" ]; then rustup target add "$TARGET"; fi
   - rustup component add rustfmt
 
 script:
-  - mkdir -p target/$TARGET;
+  - mkdir -p target/"$TARGET";
   - >
       case "$TARGET" in
         *-linux-android)     DOCKER=android ;; # Android uses a local docker image
@@ -68,6 +67,9 @@ script:
       else
           PATH="$HOME/rust/bin:$PATH" bash ci/run.sh;
       fi
+  - if [ "${TRAVIS_OS_NAME}" = linux ]; then
+      shellcheck -e SC1090 -- rustup-init.sh ci/*.sh ci/*.bash;
+    fi
 
 before_deploy:
   - bash ci/prepare-deploy-travis.sh

ci/build-run-docker.sh

@@ -28,6 +28,7 @@ if [ -f "ci/docker/$DOCKER/Dockerfile" ]; then
   travis_fold end "build.Dockerfile.${DOCKER}"
 fi
 
+# shellcheck disable=SC2016
 docker run \
   --entrypoint bash \
   --user "$(id -u)":"$(id -g)" \

ci/run.sh

@@ -2,8 +2,6 @@
 
 set -ex
 
-printf 'toolchain versions\n------------------\n'
-
 rustc -vV
 cargo -vV
 rustfmt -vV
@@ -18,11 +16,3 @@ fi
 # Check the formatting last because test failures are more interesting to have
 # discovered for contributors lacking some platform access for testing beforehand
 cargo fmt --all -- --check
-
-# Then check the shell scripts, if shellcheck is present (which it is on Travis CI)
-if command -v shellcheck > /dev/null 2>&1; then
-  shellcheck --version
-  shellcheck -- *.sh ci/*.sh
-else
-  echo No shellcheck found, skipping.
-fi

ci/shared.bash

@@ -1,7 +1,7 @@
-#!/bin/false
+#!/bin/bash
 #
-# This file is intended to be sourced, hence the invalid shebang and
-# not being marked as an executable file in git.
+# This file is intended to be sourced, so it is not being marked as
+# an executable file in git.
 
 # This is from
 # https://github.com/travis-ci/travis-build/blob/master/lib/travis/build/bash/travis_setup_env.bash