Update notification for removing component

Use update_from_dist flag for Notification::RemovingOldComponent

Rename explicit_modify param in update fn of dist manifestitation

Rename implicit_modify param in update fn of dist manifestitation

Author: BeniCheni

src/dist/dist.rs

@@ -731,6 +731,7 @@ fn try_update_from_dist_<'a>(
                 &download,
                 &download.notify_handler,
                 &toolchain.manifest_name(),
+                true,
             )? {
                 UpdateStatus::Unchanged => Ok(None),
                 UpdateStatus::Changed => Ok(Some(hash)),

src/dist/manifestation.rs

@@ -108,6 +108,7 @@ impl Manifestation {
         download_cfg: &DownloadCfg<'_>,
         notify_handler: &dyn Fn(Notification<'_>),
         toolchain_str: &str,
+        implicit_modify: bool,
     ) -> Result<UpdateStatus> {
         // Some vars we're going to need a few times
         let temp_cfg = download_cfg.temp_cfg;
@@ -168,7 +169,7 @@ impl Manifestation {
 
         // Uninstall components
         for component in &update.components_to_uninstall {
-            let notification = if altered {
+            let notification = if implicit_modify {
                 Notification::RemovingOldComponent
             } else {
                 Notification::RemovingComponent

src/toolchain.rs

@@ -710,6 +710,7 @@ impl<'a> Toolchain<'a> {
                 &self.download_cfg(),
                 &self.download_cfg().notify_handler,
                 &toolchain.manifest_name(),
+                false,
             )?;
 
             Ok(())
@@ -763,6 +764,7 @@ impl<'a> Toolchain<'a> {
                 &self.download_cfg(),
                 &self.download_cfg().notify_handler,
                 &toolchain.manifest_name(),
+                false,
             )?;
 
             Ok(())

tests/dist.rs

@@ -460,6 +460,7 @@ fn update_from_dist(
         download_cfg,
         download_cfg.notify_handler,
         &toolchain.manifest_name(),
+        true,
     )
 }