install.sh checks for rustc and cargo but not rustup.

[shaleh]

However, rustup is used at the end to install Clippy.
While it is likely uncommon to end up with rustc and cargo but not rustup it is possible.

[eirnym]

It's quite possible to end up with rust and cargo without rustup. When you install it package manager like Homebrew or MacPorts, without rustup itself. I haven't checked numerious Linux distributions and FreeBSD, but my guess is the same

For me personally it even more preferrable way to don't install rustup itself if I have way to install rust via a package manager. In other words I don't trust binaries and shell scripts from the internet

[eirnym]

By the way, rust installation from distributions like mentionend above is one of recommended ways to install rust:

https://forge.rust-lang.org/infra/other-installation-methods.html

[manyinsects]

The recommended way to install Rust has, and will likely always be rustup. I do agree that sometimes installing from distro package managers, or from source can be preferential, and I think we could probably provide an installation script flag to skip these rustup-specific checks.

[eirnym]

Please do. Rustling doesn't depend on nightly or other builds than stable. Tooling like clippy is important, and it's usually installed by a package manager

[manyinsects]

Tooling like clippy is important, and it's usually installed by a package manager

Not quite true, the recommended way to install Clippy is via rustup component add clippy :) That doesn't detract from your point, though.

[mo8it]

Closing because the installation script will be removed by #1919

After implementing #1935, Cargo should tell the user to install Clippy.

[eirnym]

@mo8it FYI, clippy and some other tooling is installed by package managers during Rust installation. I hope new way to install wouldn't depend on Nightly