Skip to content

Pre-built binaries from repo releases were not linked statically #6114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SpecterShell opened this issue Mar 13, 2024 · 4 comments
Closed

Pre-built binaries from repo releases were not linked statically #6114

SpecterShell opened this issue Mar 13, 2024 · 4 comments

Comments

@SpecterShell
Copy link

SpecterShell commented Mar 13, 2024

Related: #3075

The pre-built binary from repo releases was not statically linked and requires a DLL file that does not match the one in the latest stable Rust MSI installer.

image

@SpecterShell SpecterShell changed the title Pre-built binaries from repo releases were not built statically Pre-built binaries from repo releases were not linked statically Mar 13, 2024
@ytmimi
Copy link
Contributor

ytmimi commented Mar 13, 2024

@SpecterShell thanks for reaching out. Is rustfmt not included with the version of rust you installed with the MSI installer?

This is related to #5675. I'm pretty sure that since the 1.5.2 release rustfmt has been dynamically linked to some it's rustc dependencies, and unfortunately that's not something we can change.

rustup is the recommended distribution channel for rustfmt, and we'd discourage use of the pre-built binaries. We've also talked about removing the pre-built binaries

@calebcartwright
Copy link
Member

The pre-built binaries were always an unofficial, best effort, and we're definitely going to drop attempts to include binaries in the github releases in this repo. Afaik, no other dev tools even attempted to distribute their own binaries outside the official channel, and this team definitely does not have the bandwidth to try to take on something above and beyond standard dev tools practices.

Closing this accordingly

@calebcartwright calebcartwright closed this as not planned Won't fix, can't repro, duplicate, stale Mar 13, 2024
@SpecterShell
Copy link
Author

Thanks for your explanation!

I was asking because of microsoft/winget-pkgs#143004

Yes it is not included in the MSI installer, so I tried to add the pre-built binaries to WinGet repo but later found that they could not run without a specific version of Rust runtime.

Rustup is already available in WinGet repo though.

@calebcartwright
Copy link
Member

Thanks for your explanation!

I was asking because of microsoft/winget-pkgs#143004

Yes it is not included in the MSI installer, so I tried to add the pre-built binaries to WinGet repo but later found that they could not run without a specific version of Rust runtime.

Rustup is already available in WinGet repo though.

Got it! Thanks for the additional context.

Fully understand the reasoning and benefits, but it's unfortunately just not something we'll be able to support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants