Code with usual string not formatted

[fanatid]

Code from https://github.com/timberio/vector/blob/ff1884062e09956a7696a644f80c401e593d3e6f/src/sinks/statsd.rs but with small changes.

Code on playground not formatted: https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=f18a74b89c3b1d2a1c894c0f056bc03e

But if comment line 178, code will be formatted.

Line 178:

Bytes::from("vector.counter:1.5|c|#empty_tag:,normal_tag:value,true_tag\nvector.histogram:2|h|@0.01")

I tried cargo-fmt and rustfmt directly.

[ayazhafiz]

Simpler repro:

fn test_send_to_statsd() {
    rt.block_on_std(async move {
let sink = StatsdSvc::new(config, Acker::Null).unwrap();
        let messages = collect_n(rx, 1).compat().await.ok().unwrap();
        assert_eq(
            messages[0],
            Bytes::from("vector.counter:1.5|c|#empty_tag:,normal_tag:value,true_tag\nvector.histogram:2|h|@0.01")
        );
    });
}

[ytmimi]

Confirming that I can reproduce the issue with rustfmt 1.5.1-nightly (f2c31ba0 2022-07-19). The issue is the long string. The options to fix this issue are to increase the max_width or set format_strings=true. Note: because of the async block we need to set edition=2018.

Input

fn test_send_to_statsd() {
    rt.block_on_std(async move {
let sink = StatsdSvc::new(config, Acker::Null).unwrap();
        let messages = collect_n(rx, 1).compat().await.ok().unwrap();
        assert_eq(
            messages[0],
            Bytes::from("vector.counter:1.5|c|#empty_tag:,normal_tag:value,true_tag\nvector.histogram:2|h|@0.01")
        );
    });
}

output rustfmt --edition=2018 --config=max_width=105 (the min width I found to get it to format)

fn test_send_to_statsd() {
    rt.block_on_std(async move {
        let sink = StatsdSvc::new(config, Acker::Null).unwrap();
        let messages = collect_n(rx, 1).compat().await.ok().unwrap();
        assert_eq(
            messages[0],
            Bytes::from(
                "vector.counter:1.5|c|#empty_tag:,normal_tag:value,true_tag\nvector.histogram:2|h|@0.01",
            ),
        );
    });
}

output rustfmt --edition=2018 --config=format_strings=true

fn test_send_to_statsd() {
    rt.block_on_std(async move {
        let sink = StatsdSvc::new(config, Acker::Null).unwrap();
        let messages = collect_n(rx, 1).compat().await.ok().unwrap();
        assert_eq(
            messages[0],
            Bytes::from(
                "vector.counter:1.5|c|#empty_tag:,normal_tag:value,true_tag\nvector.histogram:\
                 2|h|@0.01",
            ),
        );
    });
}

@calebcartwright I don't think there's anything we can do at this time and I would recommend closing this

[calebcartwright]

Correct, it's another duplicate of #3863