Skip to content

failed is too strong a word for finding a line that breaks rules it can't auto fix #1451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ashleygwilliams opened this issue Apr 13, 2017 · 1 comment
Labels
good first issue Issues up for grabs, also good candidates for new rustfmt contributors

Comments

@ashleygwilliams
Copy link
Member

hi! thanks for rustfmt! it's very cool and i appreciate it a lot :)

when i saw the error below i thought it meant that Rustfmt failed, i.e. did not work properly. however it did. it simply found a thing it couldn't auto fix.

Rustfmt failed at /Users/ag_dubs/rust/sparkles/src/server.rs:120: line exceeded maximum length (maximum: 100, found: 102) (sorry)

consider using language that better describes the situation: e.g. "Rustfmt could not automatically fix"

@nrc nrc added the good first issue Issues up for grabs, also good candidates for new rustfmt contributors label Apr 30, 2017
@afshinm
Copy link
Contributor

afshinm commented Sep 15, 2017

Is this still a valid issue? I have noticed that we changed the format of errors so it says:

error: line exceeded maximum width (maximum: 100, found: 236)
  --> /Users/afshin/Projects/Github/rustfmt/a.rs:29
   |
29 | fn commit_info_fooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo(
   |                                                                                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: rustfmt may have failed to format. See previous 1 errors.

@nrc nrc closed this as completed Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues up for grabs, also good candidates for new rustfmt contributors
Projects
None yet
Development

No branches or pull requests

3 participants