-
Notifications
You must be signed in to change notification settings - Fork 153
Add winapi-rs to set of benchmarks #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Just as a note, in order for try builds to work with this we'd need some mechanism to build those on appveyor as well, which could be problematic... |
Unless we configured the travis builders to build the standard library rlibs for windows when doing a try build. It has no C dependencies for |
Seems like something we should do, then, since it'll be fairly low-overhead to produce just the std rlibs on try builds. |
Almost any crate could be cross compiled to windows-gnu from Linux host. Building the std is also simple since MinGW can be installed from the repo. |
Okay so without modifying try builds there are 2 possibilities that will work with
Another solution would be to modify Linux dist builder for try builds only by installing mingw-w64 and building |
We currently already build std on perf.rlo before every benchmark (used to be for reproducibility reasons, I believe currently not technically needed). I would be fine adding a mingw-using build to that that's optional and enabled on perf.rlo's official collection by default. I don't think we need xbuild to do so, we can probably just add on to the existing support. I would be happy to take a PR doing so. |
We may want to consider having the windows crate in addition to winapi. It's also a large code base, but it's sufficiently different in design that I think having it in addition would be useful. |
Yes, definitely! |
Opening an issue so this doesn't fall off our radar.
cc @Mark-Simulacrum @retep998
The text was updated successfully, but these errors were encountered: