Only show errors in GitHub message and show also secondary benchmarks

Author: rylev

site/src/comparison.rs

@@ -320,6 +320,10 @@ impl ComparisonSummary {
         self.comparisons.is_empty()
     }
 
+    pub fn errors_in(&self) -> &[String] {
+        &self.errors_in
+    }
+
     fn arithmetic_mean<'a>(
         &'a self,
         changes: impl Iterator<Item = &'a TestResultComparison>,
@@ -500,20 +504,6 @@ pub fn write_summary_table(
     )
     .unwrap();
 
-    if !primary.errors_in.is_empty() {
-        write!(
-            result,
-            "\nThe following benchmark(s) failed to build:\n{}\n",
-            primary
-                .errors_in
-                .iter()
-                .map(|benchmark| format!("- {benchmark}"))
-                .collect::<Vec<_>>()
-                .join("\n")
-        )
-        .unwrap();
-    }
-
     if with_footnotes {
         writeln!(
             result,

site/src/github.rs

@@ -701,6 +701,24 @@ async fn categorize_benchmark(
             secondary.unwrap_or_else(|| ComparisonSummary::empty()),
         );
         write_summary_table(&primary, &secondary, true, &mut result);
+
+        if !primary.errors_in().is_empty() || !secondary.errors_in().is_empty() {
+            let list_errored_benchmarks = |summary: ComparisonSummary| {
+                summary
+                    .errors_in()
+                    .iter()
+                    .map(|benchmark| format!("- {benchmark}"))
+                    .collect::<Vec<_>>()
+                    .join("\n")
+            };
+            write!(
+                result,
+                "\nThe following benchmark(s) failed to build:\n{}{}\n",
+                list_errored_benchmarks(primary),
+                list_errored_benchmarks(secondary)
+            )
+            .unwrap();
+        }
     }
 
     write!(result, "\n{}", DISAGREEMENT).unwrap();