Skip to content

Commit 220e713

Browse files
KobzolKobzol
authored
Merge pull request #1972 from Kobzol/triage-2024-09-03
Triage 2024 09 03
2 parents 78a3493 + ee7cd7e commit 220e713

File tree

1 file changed

+99
-0
lines changed

1 file changed

+99
-0
lines changed

‎triage/2024-09-03.md

Lines changed: 99 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,99 @@
1+
# 2024-09-03 Triage Log
2+
3+
This week we had some trouble with our performance bot, but luckily the issue has been resolved.
4+
In the end, we saw much more improvements than regressions.
5+
6+
Triage done by **@kobzol**.
7+
Revision range: [acb4e8b6..6199b69c](https://perf.rust-lang.org/?start=acb4e8b6251f1d8da36f08e7a70fa23fc581839e&end=6199b69c53a8c275ca3cd59647ea0af5ca29aae2&absolute=false&stat=instructions%3Au)
8+
9+
**Summary**:
10+
11+
| (instructions:u) | mean | range | count |
12+
|:----------------------------------:|:-----:|:--------------:|:-----:|
13+
| Regressions ❌ <br /> (primary) | 0.3% | [0.2%, 0.4%] | 8 |
14+
| Regressions ❌ <br /> (secondary) | 0.7% | [0.2%, 1.5%] | 9 |
15+
| Improvements ✅ <br /> (primary) | -0.8% | [-3.4%, -0.2%] | 158 |
16+
| Improvements ✅ <br /> (secondary) | -0.7% | [-2.3%, -0.2%] | 96 |
17+
| All ❌✅ (primary) | -0.7% | [-3.4%, 0.4%] | 166 |
18+
19+
20+
2 Regressions, 3 Improvements, 1 Mixed; 3 of them in rollups
21+
19 artifact comparisons made in total
22+
23+
#### Regressions
24+
25+
Rollup of 7 pull requests [#129750](https://github.com/rust-lang/rust/pull/129750) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=784d444733d65c3d305ce5edcbb41e3d0d0aee2e&end=0d634185dfddefe09047881175f35c65d68dcff1&stat=instructions:u)
26+
27+
| (instructions:u) | mean | range | count |
28+
|:----------------------------------:|:----:|:------------:|:-----:|
29+
| Regressions ❌ <br /> (primary) | 0.4% | [0.3%, 0.5%] | 7 |
30+
| Regressions ❌ <br /> (secondary) | 6.0% | [6.0%, 6.0%] | 1 |
31+
| Improvements ✅ <br /> (primary) | - | - | 0 |
32+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
33+
| All ❌✅ (primary) | 0.4% | [0.3%, 0.5%] | 7 |
34+
35+
- This was bimodal noise.
36+
37+
Rollup of 8 pull requests [#129922](https://github.com/rust-lang/rust/pull/129922) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=6199b69c53a8c275ca3cd59647ea0af5ca29aae2&end=d6c8169c186ab16a3404cd0d0866674018e8a19e&stat=instructions:u)
38+
39+
| (instructions:u) | mean | range | count |
40+
|:----------------------------------:|:----:|:------------:|:-----:|
41+
| Regressions ❌ <br /> (primary) | - | - | 0 |
42+
| Regressions ❌ <br /> (secondary) | 5.8% | [5.8%, 5.8%] | 1 |
43+
| Improvements ✅ <br /> (primary) | - | - | 0 |
44+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
45+
| All ❌✅ (primary) | - | - | 0 |
46+
47+
- Likely the same story, just with a different benchmark.
48+
- Not marking as triaged yet.
49+
50+
#### Improvements
51+
52+
Rollup of 15 pull requests [#129809](https://github.com/rust-lang/rust/pull/129809) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=fa72f0763de6bc1596208fc1419883ce5aea0de4&end=9649706eada1b2c68cf6504356efb058f68ad739&stat=instructions:u)
53+
54+
| (instructions:u) | mean | range | count |
55+
|:----------------------------------:|:-----:|:--------------:|:-----:|
56+
| Regressions ❌ <br /> (primary) | - | - | 0 |
57+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
58+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.9%, -0.2%] | 21 |
59+
| Improvements ✅ <br /> (secondary) | -0.7% | [-5.9%, -0.1%] | 18 |
60+
| All ❌✅ (primary) | -0.3% | [-0.9%, -0.2%] | 21 |
61+
62+
63+
Revert "Auto merge of #127537 - veluca93:struct_tf, r=BoxyUwU" [#129854](https://github.com/rust-lang/rust/pull/129854) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=a48861a6279b386ad2b9c3518490181d238fe727&end=94885bc699512cfee8560e73c2a01ee6b4b76563&stat=instructions:u)
64+
65+
| (instructions:u) | mean | range | count |
66+
|:----------------------------------:|:-----:|:--------------:|:-----:|
67+
| Regressions ❌ <br /> (primary) | - | - | 0 |
68+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
69+
| Improvements ✅ <br /> (primary) | -0.4% | [-1.1%, -0.2%] | 81 |
70+
| Improvements ✅ <br /> (secondary) | -0.5% | [-2.2%, -0.2%] | 24 |
71+
| All ❌✅ (primary) | -0.4% | [-1.1%, -0.2%] | 81 |
72+
73+
- Revert of an earlier PR that had larger than expected regressions.
74+
- Investigation is ongoing on how to land it without such large regressions.
75+
76+
Apply size optimizations to panic machinery and some cold functions [#129063](https://github.com/rust-lang/rust/pull/129063) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=94885bc699512cfee8560e73c2a01ee6b4b76563&end=e71f9529121ca8f687e4b725e3c9adc3f1ebab4d&stat=instructions:u)
77+
78+
| (instructions:u) | mean | range | count |
79+
|:----------------------------------:|:-----:|:--------------:|:-----:|
80+
| Regressions ❌ <br /> (primary) | 0.2% | [0.2%, 0.2%] | 2 |
81+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
82+
| Improvements ✅ <br /> (primary) | -1.2% | [-3.0%, -0.3%] | 16 |
83+
| Improvements ✅ <br /> (secondary) | -1.0% | [-1.5%, -0.4%] | 4 |
84+
| All ❌✅ (primary) | -1.0% | [-3.0%, 0.2%] | 18 |
85+
86+
87+
#### Mixed
88+
89+
Rewrite lint_expectations in a single pass. [#127313](https://github.com/rust-lang/rust/pull/127313) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=1a1cc050d8efc906ede39f444936ade1fdc9c6cb&end=a48861a6279b386ad2b9c3518490181d238fe727&stat=instructions:u)
90+
91+
| (instructions:u) | mean | range | count |
92+
|:----------------------------------:|:-----:|:--------------:|:-----:|
93+
| Regressions ❌ <br /> (primary) | 0.4% | [0.3%, 0.4%] | 9 |
94+
| Regressions ❌ <br /> (secondary) | 0.6% | [0.2%, 1.5%] | 14 |
95+
| Improvements ✅ <br /> (primary) | -0.5% | [-1.5%, -0.2%] | 82 |
96+
| Improvements ✅ <br /> (secondary) | -0.7% | [-1.8%, -0.1%] | 58 |
97+
| All ❌✅ (primary) | -0.4% | [-1.5%, 0.4%] | 91 |
98+
99+
- More improvements than regressions, marking as triaged.

0 commit comments

Comments
 (0)