From 387675366868e19fe1a9542afa2738b8f9ca23de Mon Sep 17 00:00:00 2001 From: Jakob Degen Date: Fri, 22 Oct 2021 23:21:46 -0400 Subject: [PATCH 1/6] Add diagnostic in case of failed `.try_into()` method call pre-Edition 2021 --- compiler/rustc_typeck/src/check/method/suggest.rs | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/compiler/rustc_typeck/src/check/method/suggest.rs b/compiler/rustc_typeck/src/check/method/suggest.rs index 183ebc559ae42..28b19981c2d40 100644 --- a/compiler/rustc_typeck/src/check/method/suggest.rs +++ b/compiler/rustc_typeck/src/check/method/suggest.rs @@ -1203,6 +1203,13 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> { let mut candidates = valid_out_of_scope_traits; candidates.sort(); candidates.dedup(); + + // `TryFrom` and `FromIterator` have no methods + let edition_fix = candidates + .iter() + .find(|did| self.tcx.is_diagnostic_item(sym::TryInto, **did)) + .map(|&d| d); + err.help("items from traits can only be used if the trait is in scope"); let msg = format!( "the following {traits_are} implemented but not in scope; \ @@ -1212,6 +1219,13 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> { ); self.suggest_use_candidates(err, msg, candidates); + if let Some(did) = edition_fix { + err.note(&format!( + "'{}' is included in the prelude starting in Edition 2021", + with_crate_prefix(|| self.tcx.def_path_str(did)) + )); + } + true } else { false From e91d5ca197b966b841c4e49c921215a69f9d9c19 Mon Sep 17 00:00:00 2001 From: Jakob Degen Date: Sun, 24 Oct 2021 21:09:52 -0400 Subject: [PATCH 2/6] Add test checking that Edition 2021 is suggested for .try_into() and fix other test --- .../future-prelude-collision-shadow.stderr | 1 + .../suggest-tryinto-edition-change.rs | 11 ++++++++++ .../suggest-tryinto-edition-change.stderr | 21 +++++++++++++++++++ 3 files changed, 33 insertions(+) create mode 100644 src/test/ui/suggestions/suggest-tryinto-edition-change.rs create mode 100644 src/test/ui/suggestions/suggest-tryinto-edition-change.stderr diff --git a/src/test/ui/rust-2021/future-prelude-collision-shadow.stderr b/src/test/ui/rust-2021/future-prelude-collision-shadow.stderr index e4662b430dccc..d945b4c94ca2f 100644 --- a/src/test/ui/rust-2021/future-prelude-collision-shadow.stderr +++ b/src/test/ui/rust-2021/future-prelude-collision-shadow.stderr @@ -15,6 +15,7 @@ LL | fn try_into(self) -> Result; | the method is available for `Rc` here | = help: items from traits can only be used if the trait is in scope + = note: 'std::convert::TryInto' is included in the prelude starting in Edition 2021 help: consider wrapping the receiver expression with the appropriate type | LL | let _: u32 = Box::new(3u8).try_into().unwrap(); diff --git a/src/test/ui/suggestions/suggest-tryinto-edition-change.rs b/src/test/ui/suggestions/suggest-tryinto-edition-change.rs new file mode 100644 index 0000000000000..f60ef587cfaad --- /dev/null +++ b/src/test/ui/suggestions/suggest-tryinto-edition-change.rs @@ -0,0 +1,11 @@ +// Make sure that calling `.try_into()` in pre-2021 mentions Edition 2021 change +// edition:2018 + +fn test() { + let i: i16 = 0_i32.try_into().unwrap(); + //~^ ERROR no method named `try_into` found for type `i32` in the current scope + //~| NOTE method not found in `i32` + //~| NOTE 'std::convert::TryInto' is included in the prelude starting in Edition 2021 +} + +fn main() {} diff --git a/src/test/ui/suggestions/suggest-tryinto-edition-change.stderr b/src/test/ui/suggestions/suggest-tryinto-edition-change.stderr new file mode 100644 index 0000000000000..7915937023c0f --- /dev/null +++ b/src/test/ui/suggestions/suggest-tryinto-edition-change.stderr @@ -0,0 +1,21 @@ +error[E0599]: no method named `try_into` found for type `i32` in the current scope + --> $DIR/suggest-tryinto-edition-change.rs:5:24 + | +LL | let i: i16 = 0_i32.try_into().unwrap(); + | ^^^^^^^^ method not found in `i32` + | + ::: $SRC_DIR/core/src/convert/mod.rs:LL:COL + | +LL | fn try_into(self) -> Result; + | -------- the method is available for `i32` here + | + = help: items from traits can only be used if the trait is in scope + = note: 'std::convert::TryInto' is included in the prelude starting in Edition 2021 +help: the following trait is implemented but not in scope; perhaps add a `use` for it: + | +LL | use std::convert::TryInto; + | + +error: aborting due to previous error + +For more information about this error, try `rustc --explain E0599`. From 958e64594672ccd11fba5ec6925e33ef223301ee Mon Sep 17 00:00:00 2001 From: Jakob Degen Date: Mon, 25 Oct 2021 20:04:35 -0400 Subject: [PATCH 3/6] Adds hint if a trait fails to resolve and a newly added one in Edition 2021 is suggested --- compiler/rustc_resolve/src/diagnostics.rs | 57 ++++++++++++++-- .../rustc_resolve/src/late/diagnostics.rs | 1 + .../suggest-tryinto-edition-change.rs | 26 +++++++- .../suggest-tryinto-edition-change.stderr | 65 +++++++++++++++++-- 4 files changed, 134 insertions(+), 15 deletions(-) diff --git a/compiler/rustc_resolve/src/diagnostics.rs b/compiler/rustc_resolve/src/diagnostics.rs index f94266c3aeaf0..57acca16d94a8 100644 --- a/compiler/rustc_resolve/src/diagnostics.rs +++ b/compiler/rustc_resolve/src/diagnostics.rs @@ -66,6 +66,8 @@ crate struct ImportSuggestion { pub descr: &'static str, pub path: Path, pub accessible: bool, + /// An extra note that should be issued if this item is suggested + pub note: Option, } /// Adjust the impl span so that just the `impl` keyword is taken by removing @@ -872,11 +874,38 @@ impl<'a> Resolver<'a> { } if candidates.iter().all(|v: &ImportSuggestion| v.did != did) { + // See if we're recommending TryFrom, TryInto, or FromIterator and add + // a note about editions + let note = if let Some(did) = did { + let requires_note = !did.is_local() + && this.cstore().item_attrs(did, this.session).iter().any( + |attr| { + if attr.has_name(sym::rustc_diagnostic_item) { + [sym::TryInto, sym::TryFrom, sym::FromIterator] + .map(|x| Some(x)) + .contains(&attr.value_str()) + } else { + false + } + }, + ); + + requires_note.then(|| { + format!( + "'{}' is included in the prelude starting in Edition 2021", + path_names_to_string(&path) + ) + }) + } else { + None + }; + candidates.push(ImportSuggestion { did, descr: res.descr(), path, accessible: child_accessible, + note, }); } } @@ -1764,12 +1793,14 @@ crate fn show_candidates( return; } - let mut accessible_path_strings: Vec<(String, &str, Option)> = Vec::new(); - let mut inaccessible_path_strings: Vec<(String, &str, Option)> = Vec::new(); + let mut accessible_path_strings: Vec<(String, &str, Option, &Option)> = + Vec::new(); + let mut inaccessible_path_strings: Vec<(String, &str, Option, &Option)> = + Vec::new(); candidates.iter().for_each(|c| { (if c.accessible { &mut accessible_path_strings } else { &mut inaccessible_path_strings }) - .push((path_names_to_string(&c.path), c.descr, c.did)) + .push((path_names_to_string(&c.path), c.descr, c.did, &c.note)) }); // we want consistent results across executions, but candidates are produced @@ -1792,6 +1823,11 @@ crate fn show_candidates( let instead = if instead { " instead" } else { "" }; let mut msg = format!("consider importing {} {}{}", determiner, kind, instead); + // Issue notes + for note in accessible_path_strings.iter().map(|cand| cand.3.as_ref()).flatten() { + err.note(note); + } + if let Some(span) = use_placement_span { for candidate in &mut accessible_path_strings { // produce an additional newline to separate the new use statement @@ -1820,7 +1856,7 @@ crate fn show_candidates( assert!(!inaccessible_path_strings.is_empty()); if inaccessible_path_strings.len() == 1 { - let (name, descr, def_id) = &inaccessible_path_strings[0]; + let (name, descr, def_id, note) = &inaccessible_path_strings[0]; let msg = format!("{} `{}` exists but is inaccessible", descr, name); if let Some(local_def_id) = def_id.and_then(|did| did.as_local()) { @@ -1832,12 +1868,15 @@ crate fn show_candidates( } else { err.note(&msg); } + if let Some(note) = (*note).as_deref() { + err.note(note); + } } else { - let (_, descr_first, _) = &inaccessible_path_strings[0]; + let (_, descr_first, _, _) = &inaccessible_path_strings[0]; let descr = if inaccessible_path_strings .iter() .skip(1) - .all(|(_, descr, _)| descr == descr_first) + .all(|(_, descr, _, _)| descr == descr_first) { descr_first.to_string() } else { @@ -1848,7 +1887,7 @@ crate fn show_candidates( let mut has_colon = false; let mut spans = Vec::new(); - for (name, _, def_id) in &inaccessible_path_strings { + for (name, _, def_id, _) in &inaccessible_path_strings { if let Some(local_def_id) = def_id.and_then(|did| did.as_local()) { let span = definitions.def_span(local_def_id); let span = session.source_map().guess_head_span(span); @@ -1868,6 +1907,10 @@ crate fn show_candidates( multi_span.push_span_label(span, format!("`{}`: not accessible", name)); } + for note in inaccessible_path_strings.iter().map(|cand| cand.3.as_ref()).flatten() { + err.note(note); + } + err.span_note(multi_span, &msg); } } diff --git a/compiler/rustc_resolve/src/late/diagnostics.rs b/compiler/rustc_resolve/src/late/diagnostics.rs index 1748a9be8e13e..5f90fcdfa64e2 100644 --- a/compiler/rustc_resolve/src/late/diagnostics.rs +++ b/compiler/rustc_resolve/src/late/diagnostics.rs @@ -1502,6 +1502,7 @@ impl<'a: 'ast, 'ast> LateResolutionVisitor<'a, '_, 'ast> { descr: "module", path, accessible: true, + note: None, }, )); } else { diff --git a/src/test/ui/suggestions/suggest-tryinto-edition-change.rs b/src/test/ui/suggestions/suggest-tryinto-edition-change.rs index f60ef587cfaad..f03b42bbe4751 100644 --- a/src/test/ui/suggestions/suggest-tryinto-edition-change.rs +++ b/src/test/ui/suggestions/suggest-tryinto-edition-change.rs @@ -1,11 +1,31 @@ -// Make sure that calling `.try_into()` in pre-2021 mentions Edition 2021 change +// Make sure that trying to access `TryInto`, `TryFrom`, `FromIterator` in pre-2021 mentions +// Edition 2021 change // edition:2018 fn test() { - let i: i16 = 0_i32.try_into().unwrap(); + let _i: i16 = 0_i32.try_into().unwrap(); //~^ ERROR no method named `try_into` found for type `i32` in the current scope //~| NOTE method not found in `i32` //~| NOTE 'std::convert::TryInto' is included in the prelude starting in Edition 2021 + + let _i: i16 = TryFrom::try_from(0_i32).unwrap(); + //~^ ERROR failed to resolve: use of undeclared type + //~| NOTE not found in this scope + //~| NOTE 'std::convert::TryFrom' is included in the prelude starting in Edition 2021 + //~| NOTE 'core::convert::TryFrom' is included in the prelude starting in Edition 2021 + + let _i: i16 = TryInto::try_into(0_i32).unwrap(); + //~^ ERROR failed to resolve: use of undeclared type + //~| NOTE not found in this scope + //~| NOTE 'std::convert::TryInto' is included in the prelude starting in Edition 2021 + //~| NOTE 'core::convert::TryInto' is included in the prelude starting in Edition 2021 + + let _v: Vec<_> = FromIterator::from_iter(&[1]); + //~^ ERROR failed to resolve: use of undeclared type + //~| NOTE 'std::iter::FromIterator' is included in the prelude starting in Edition 2021 + //~| NOTE 'core::iter::FromIterator' is included in the prelude starting in Edition 2021 } -fn main() {} +fn main() { + test(); +} diff --git a/src/test/ui/suggestions/suggest-tryinto-edition-change.stderr b/src/test/ui/suggestions/suggest-tryinto-edition-change.stderr index 7915937023c0f..80191ec4fd7b4 100644 --- a/src/test/ui/suggestions/suggest-tryinto-edition-change.stderr +++ b/src/test/ui/suggestions/suggest-tryinto-edition-change.stderr @@ -1,8 +1,62 @@ +error[E0433]: failed to resolve: use of undeclared type `TryFrom` + --> $DIR/suggest-tryinto-edition-change.rs:11:19 + | +LL | let _i: i16 = TryFrom::try_from(0_i32).unwrap(); + | ^^^^^^^ not found in this scope + | + = note: 'std::convert::TryFrom' is included in the prelude starting in Edition 2021 + = note: 'core::convert::TryFrom' is included in the prelude starting in Edition 2021 +help: consider importing one of these items + | +LL | use std::convert::TryFrom; + | +LL | use core::convert::TryFrom; + | + +error[E0433]: failed to resolve: use of undeclared type `TryInto` + --> $DIR/suggest-tryinto-edition-change.rs:17:19 + | +LL | let _i: i16 = TryInto::try_into(0_i32).unwrap(); + | ^^^^^^^ not found in this scope + | + = note: 'std::convert::TryInto' is included in the prelude starting in Edition 2021 + = note: 'core::convert::TryInto' is included in the prelude starting in Edition 2021 +help: consider importing one of these items + | +LL | use std::convert::TryInto; + | +LL | use core::convert::TryInto; + | + +error[E0433]: failed to resolve: use of undeclared type `FromIterator` + --> $DIR/suggest-tryinto-edition-change.rs:23:22 + | +LL | let _v: Vec<_> = FromIterator::from_iter(&[1]); + | ^^^^^^^^^^^^ + | + ::: $SRC_DIR/core/src/iter/traits/collect.rs:LL:COL + | +LL | pub trait IntoIterator { + | ---------------------- similarly named trait `IntoIterator` defined here + | + = note: 'std::iter::FromIterator' is included in the prelude starting in Edition 2021 + = note: 'core::iter::FromIterator' is included in the prelude starting in Edition 2021 +help: a trait with a similar name exists + | +LL | let _v: Vec<_> = IntoIterator::from_iter(&[1]); + | ~~~~~~~~~~~~ +help: consider importing one of these items + | +LL | use std::iter::FromIterator; + | +LL | use core::iter::FromIterator; + | + error[E0599]: no method named `try_into` found for type `i32` in the current scope - --> $DIR/suggest-tryinto-edition-change.rs:5:24 + --> $DIR/suggest-tryinto-edition-change.rs:6:25 | -LL | let i: i16 = 0_i32.try_into().unwrap(); - | ^^^^^^^^ method not found in `i32` +LL | let _i: i16 = 0_i32.try_into().unwrap(); + | ^^^^^^^^ method not found in `i32` | ::: $SRC_DIR/core/src/convert/mod.rs:LL:COL | @@ -16,6 +70,7 @@ help: the following trait is implemented but not in scope; perhaps add a `use` f LL | use std::convert::TryInto; | -error: aborting due to previous error +error: aborting due to 4 previous errors -For more information about this error, try `rustc --explain E0599`. +Some errors have detailed explanations: E0433, E0599. +For more information about an error, try `rustc --explain E0433`. From 6ce3ae4b73b678c8c50fc9844ede20aaa214ad10 Mon Sep 17 00:00:00 2001 From: Jakob Degen Date: Mon, 25 Oct 2021 22:56:18 -0400 Subject: [PATCH 4/6] Make `ui/suggestions/suggest-tryinto-edition-change.rs` no_std to avoid getting inconsistent output between local and CI. --- .../suggest-tryinto-edition-change.rs | 24 +++++----- .../suggest-tryinto-edition-change.stderr | 47 ++++++++----------- 2 files changed, 30 insertions(+), 41 deletions(-) diff --git a/src/test/ui/suggestions/suggest-tryinto-edition-change.rs b/src/test/ui/suggestions/suggest-tryinto-edition-change.rs index f03b42bbe4751..e62990144c4c3 100644 --- a/src/test/ui/suggestions/suggest-tryinto-edition-change.rs +++ b/src/test/ui/suggestions/suggest-tryinto-edition-change.rs @@ -2,30 +2,28 @@ // Edition 2021 change // edition:2018 -fn test() { - let _i: i16 = 0_i32.try_into().unwrap(); +// We mark this no_std to avoid emitting suggestions for both `std` and `core` traits. These were +// inconsistently ordered between CI and at least one local build, causing test failures. +#![no_std] +#![crate_type = "lib"] + +pub fn test() { + let _i: Result = 0_i32.try_into(); //~^ ERROR no method named `try_into` found for type `i32` in the current scope //~| NOTE method not found in `i32` - //~| NOTE 'std::convert::TryInto' is included in the prelude starting in Edition 2021 + //~| NOTE 'core::convert::TryInto' is included in the prelude starting in Edition 2021 - let _i: i16 = TryFrom::try_from(0_i32).unwrap(); + let _i: Result = TryFrom::try_from(0_i32); //~^ ERROR failed to resolve: use of undeclared type //~| NOTE not found in this scope - //~| NOTE 'std::convert::TryFrom' is included in the prelude starting in Edition 2021 //~| NOTE 'core::convert::TryFrom' is included in the prelude starting in Edition 2021 - let _i: i16 = TryInto::try_into(0_i32).unwrap(); + let _i: Result = TryInto::try_into(0_i32); //~^ ERROR failed to resolve: use of undeclared type //~| NOTE not found in this scope - //~| NOTE 'std::convert::TryInto' is included in the prelude starting in Edition 2021 //~| NOTE 'core::convert::TryInto' is included in the prelude starting in Edition 2021 - let _v: Vec<_> = FromIterator::from_iter(&[1]); + let _i: () = FromIterator::from_iter(core::iter::empty()); //~^ ERROR failed to resolve: use of undeclared type - //~| NOTE 'std::iter::FromIterator' is included in the prelude starting in Edition 2021 //~| NOTE 'core::iter::FromIterator' is included in the prelude starting in Edition 2021 } - -fn main() { - test(); -} diff --git a/src/test/ui/suggestions/suggest-tryinto-edition-change.stderr b/src/test/ui/suggestions/suggest-tryinto-edition-change.stderr index 80191ec4fd7b4..e7013063d4524 100644 --- a/src/test/ui/suggestions/suggest-tryinto-edition-change.stderr +++ b/src/test/ui/suggestions/suggest-tryinto-edition-change.stderr @@ -1,62 +1,53 @@ error[E0433]: failed to resolve: use of undeclared type `TryFrom` - --> $DIR/suggest-tryinto-edition-change.rs:11:19 + --> $DIR/suggest-tryinto-edition-change.rs:14:30 | -LL | let _i: i16 = TryFrom::try_from(0_i32).unwrap(); - | ^^^^^^^ not found in this scope +LL | let _i: Result = TryFrom::try_from(0_i32); + | ^^^^^^^ not found in this scope | - = note: 'std::convert::TryFrom' is included in the prelude starting in Edition 2021 = note: 'core::convert::TryFrom' is included in the prelude starting in Edition 2021 -help: consider importing one of these items - | -LL | use std::convert::TryFrom; +help: consider importing this trait | LL | use core::convert::TryFrom; | error[E0433]: failed to resolve: use of undeclared type `TryInto` - --> $DIR/suggest-tryinto-edition-change.rs:17:19 + --> $DIR/suggest-tryinto-edition-change.rs:19:30 | -LL | let _i: i16 = TryInto::try_into(0_i32).unwrap(); - | ^^^^^^^ not found in this scope +LL | let _i: Result = TryInto::try_into(0_i32); + | ^^^^^^^ not found in this scope | - = note: 'std::convert::TryInto' is included in the prelude starting in Edition 2021 = note: 'core::convert::TryInto' is included in the prelude starting in Edition 2021 -help: consider importing one of these items - | -LL | use std::convert::TryInto; +help: consider importing this trait | LL | use core::convert::TryInto; | error[E0433]: failed to resolve: use of undeclared type `FromIterator` - --> $DIR/suggest-tryinto-edition-change.rs:23:22 + --> $DIR/suggest-tryinto-edition-change.rs:24:18 | -LL | let _v: Vec<_> = FromIterator::from_iter(&[1]); - | ^^^^^^^^^^^^ +LL | let _i: () = FromIterator::from_iter(core::iter::empty()); + | ^^^^^^^^^^^^ | ::: $SRC_DIR/core/src/iter/traits/collect.rs:LL:COL | LL | pub trait IntoIterator { | ---------------------- similarly named trait `IntoIterator` defined here | - = note: 'std::iter::FromIterator' is included in the prelude starting in Edition 2021 = note: 'core::iter::FromIterator' is included in the prelude starting in Edition 2021 help: a trait with a similar name exists | -LL | let _v: Vec<_> = IntoIterator::from_iter(&[1]); - | ~~~~~~~~~~~~ -help: consider importing one of these items - | -LL | use std::iter::FromIterator; +LL | let _i: () = IntoIterator::from_iter(core::iter::empty()); + | ~~~~~~~~~~~~ +help: consider importing this trait | LL | use core::iter::FromIterator; | error[E0599]: no method named `try_into` found for type `i32` in the current scope - --> $DIR/suggest-tryinto-edition-change.rs:6:25 + --> $DIR/suggest-tryinto-edition-change.rs:9:36 | -LL | let _i: i16 = 0_i32.try_into().unwrap(); - | ^^^^^^^^ method not found in `i32` +LL | let _i: Result = 0_i32.try_into(); + | ^^^^^^^^ method not found in `i32` | ::: $SRC_DIR/core/src/convert/mod.rs:LL:COL | @@ -64,10 +55,10 @@ LL | fn try_into(self) -> Result; | -------- the method is available for `i32` here | = help: items from traits can only be used if the trait is in scope - = note: 'std::convert::TryInto' is included in the prelude starting in Edition 2021 + = note: 'core::convert::TryInto' is included in the prelude starting in Edition 2021 help: the following trait is implemented but not in scope; perhaps add a `use` for it: | -LL | use std::convert::TryInto; +LL | use core::convert::TryInto; | error: aborting due to 4 previous errors From e41ef3643596440f459cfd6ec1b4997f9d123dc2 Mon Sep 17 00:00:00 2001 From: Jakob Degen Date: Mon, 25 Oct 2021 23:14:48 -0400 Subject: [PATCH 5/6] Fix line numbers in test --- .../ui/suggestions/suggest-tryinto-edition-change.stderr | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/ui/suggestions/suggest-tryinto-edition-change.stderr b/src/test/ui/suggestions/suggest-tryinto-edition-change.stderr index e7013063d4524..e27c532dcf0e8 100644 --- a/src/test/ui/suggestions/suggest-tryinto-edition-change.stderr +++ b/src/test/ui/suggestions/suggest-tryinto-edition-change.stderr @@ -1,5 +1,5 @@ error[E0433]: failed to resolve: use of undeclared type `TryFrom` - --> $DIR/suggest-tryinto-edition-change.rs:14:30 + --> $DIR/suggest-tryinto-edition-change.rs:16:30 | LL | let _i: Result = TryFrom::try_from(0_i32); | ^^^^^^^ not found in this scope @@ -11,7 +11,7 @@ LL | use core::convert::TryFrom; | error[E0433]: failed to resolve: use of undeclared type `TryInto` - --> $DIR/suggest-tryinto-edition-change.rs:19:30 + --> $DIR/suggest-tryinto-edition-change.rs:21:30 | LL | let _i: Result = TryInto::try_into(0_i32); | ^^^^^^^ not found in this scope @@ -23,7 +23,7 @@ LL | use core::convert::TryInto; | error[E0433]: failed to resolve: use of undeclared type `FromIterator` - --> $DIR/suggest-tryinto-edition-change.rs:24:18 + --> $DIR/suggest-tryinto-edition-change.rs:26:18 | LL | let _i: () = FromIterator::from_iter(core::iter::empty()); | ^^^^^^^^^^^^ @@ -44,7 +44,7 @@ LL | use core::iter::FromIterator; | error[E0599]: no method named `try_into` found for type `i32` in the current scope - --> $DIR/suggest-tryinto-edition-change.rs:9:36 + --> $DIR/suggest-tryinto-edition-change.rs:11:36 | LL | let _i: Result = 0_i32.try_into(); | ^^^^^^^^ method not found in `i32` From cb336f1f677374e463ffa1a1fcc32ce398cb4cbe Mon Sep 17 00:00:00 2001 From: Jakob Degen Date: Tue, 26 Oct 2021 21:18:04 -0400 Subject: [PATCH 6/6] Reverting switching test to no_std and adjust output after rebase. --- compiler/rustc_resolve/src/diagnostics.rs | 1 - .../suggest-tryinto-edition-change.rs | 24 +++++----- .../suggest-tryinto-edition-change.stderr | 47 +++++++++++-------- 3 files changed, 41 insertions(+), 31 deletions(-) diff --git a/compiler/rustc_resolve/src/diagnostics.rs b/compiler/rustc_resolve/src/diagnostics.rs index 57acca16d94a8..ccfab263bd48e 100644 --- a/compiler/rustc_resolve/src/diagnostics.rs +++ b/compiler/rustc_resolve/src/diagnostics.rs @@ -1823,7 +1823,6 @@ crate fn show_candidates( let instead = if instead { " instead" } else { "" }; let mut msg = format!("consider importing {} {}{}", determiner, kind, instead); - // Issue notes for note in accessible_path_strings.iter().map(|cand| cand.3.as_ref()).flatten() { err.note(note); } diff --git a/src/test/ui/suggestions/suggest-tryinto-edition-change.rs b/src/test/ui/suggestions/suggest-tryinto-edition-change.rs index e62990144c4c3..f03b42bbe4751 100644 --- a/src/test/ui/suggestions/suggest-tryinto-edition-change.rs +++ b/src/test/ui/suggestions/suggest-tryinto-edition-change.rs @@ -2,28 +2,30 @@ // Edition 2021 change // edition:2018 -// We mark this no_std to avoid emitting suggestions for both `std` and `core` traits. These were -// inconsistently ordered between CI and at least one local build, causing test failures. -#![no_std] -#![crate_type = "lib"] - -pub fn test() { - let _i: Result = 0_i32.try_into(); +fn test() { + let _i: i16 = 0_i32.try_into().unwrap(); //~^ ERROR no method named `try_into` found for type `i32` in the current scope //~| NOTE method not found in `i32` - //~| NOTE 'core::convert::TryInto' is included in the prelude starting in Edition 2021 + //~| NOTE 'std::convert::TryInto' is included in the prelude starting in Edition 2021 - let _i: Result = TryFrom::try_from(0_i32); + let _i: i16 = TryFrom::try_from(0_i32).unwrap(); //~^ ERROR failed to resolve: use of undeclared type //~| NOTE not found in this scope + //~| NOTE 'std::convert::TryFrom' is included in the prelude starting in Edition 2021 //~| NOTE 'core::convert::TryFrom' is included in the prelude starting in Edition 2021 - let _i: Result = TryInto::try_into(0_i32); + let _i: i16 = TryInto::try_into(0_i32).unwrap(); //~^ ERROR failed to resolve: use of undeclared type //~| NOTE not found in this scope + //~| NOTE 'std::convert::TryInto' is included in the prelude starting in Edition 2021 //~| NOTE 'core::convert::TryInto' is included in the prelude starting in Edition 2021 - let _i: () = FromIterator::from_iter(core::iter::empty()); + let _v: Vec<_> = FromIterator::from_iter(&[1]); //~^ ERROR failed to resolve: use of undeclared type + //~| NOTE 'std::iter::FromIterator' is included in the prelude starting in Edition 2021 //~| NOTE 'core::iter::FromIterator' is included in the prelude starting in Edition 2021 } + +fn main() { + test(); +} diff --git a/src/test/ui/suggestions/suggest-tryinto-edition-change.stderr b/src/test/ui/suggestions/suggest-tryinto-edition-change.stderr index e27c532dcf0e8..86f48716b16b5 100644 --- a/src/test/ui/suggestions/suggest-tryinto-edition-change.stderr +++ b/src/test/ui/suggestions/suggest-tryinto-edition-change.stderr @@ -1,53 +1,62 @@ error[E0433]: failed to resolve: use of undeclared type `TryFrom` - --> $DIR/suggest-tryinto-edition-change.rs:16:30 + --> $DIR/suggest-tryinto-edition-change.rs:11:19 | -LL | let _i: Result = TryFrom::try_from(0_i32); - | ^^^^^^^ not found in this scope +LL | let _i: i16 = TryFrom::try_from(0_i32).unwrap(); + | ^^^^^^^ not found in this scope | + = note: 'std::convert::TryFrom' is included in the prelude starting in Edition 2021 = note: 'core::convert::TryFrom' is included in the prelude starting in Edition 2021 -help: consider importing this trait +help: consider importing one of these items | LL | use core::convert::TryFrom; | +LL | use std::convert::TryFrom; + | error[E0433]: failed to resolve: use of undeclared type `TryInto` - --> $DIR/suggest-tryinto-edition-change.rs:21:30 + --> $DIR/suggest-tryinto-edition-change.rs:17:19 | -LL | let _i: Result = TryInto::try_into(0_i32); - | ^^^^^^^ not found in this scope +LL | let _i: i16 = TryInto::try_into(0_i32).unwrap(); + | ^^^^^^^ not found in this scope | + = note: 'std::convert::TryInto' is included in the prelude starting in Edition 2021 = note: 'core::convert::TryInto' is included in the prelude starting in Edition 2021 -help: consider importing this trait +help: consider importing one of these items | LL | use core::convert::TryInto; | +LL | use std::convert::TryInto; + | error[E0433]: failed to resolve: use of undeclared type `FromIterator` - --> $DIR/suggest-tryinto-edition-change.rs:26:18 + --> $DIR/suggest-tryinto-edition-change.rs:23:22 | -LL | let _i: () = FromIterator::from_iter(core::iter::empty()); - | ^^^^^^^^^^^^ +LL | let _v: Vec<_> = FromIterator::from_iter(&[1]); + | ^^^^^^^^^^^^ | ::: $SRC_DIR/core/src/iter/traits/collect.rs:LL:COL | LL | pub trait IntoIterator { | ---------------------- similarly named trait `IntoIterator` defined here | + = note: 'std::iter::FromIterator' is included in the prelude starting in Edition 2021 = note: 'core::iter::FromIterator' is included in the prelude starting in Edition 2021 help: a trait with a similar name exists | -LL | let _i: () = IntoIterator::from_iter(core::iter::empty()); - | ~~~~~~~~~~~~ -help: consider importing this trait +LL | let _v: Vec<_> = IntoIterator::from_iter(&[1]); + | ~~~~~~~~~~~~ +help: consider importing one of these items | LL | use core::iter::FromIterator; | +LL | use std::iter::FromIterator; + | error[E0599]: no method named `try_into` found for type `i32` in the current scope - --> $DIR/suggest-tryinto-edition-change.rs:11:36 + --> $DIR/suggest-tryinto-edition-change.rs:6:25 | -LL | let _i: Result = 0_i32.try_into(); - | ^^^^^^^^ method not found in `i32` +LL | let _i: i16 = 0_i32.try_into().unwrap(); + | ^^^^^^^^ method not found in `i32` | ::: $SRC_DIR/core/src/convert/mod.rs:LL:COL | @@ -55,10 +64,10 @@ LL | fn try_into(self) -> Result; | -------- the method is available for `i32` here | = help: items from traits can only be used if the trait is in scope - = note: 'core::convert::TryInto' is included in the prelude starting in Edition 2021 + = note: 'std::convert::TryInto' is included in the prelude starting in Edition 2021 help: the following trait is implemented but not in scope; perhaps add a `use` for it: | -LL | use core::convert::TryInto; +LL | use std::convert::TryInto; | error: aborting due to 4 previous errors