From 8408012ca4ed6e8e0aa2aa85e24eb53b4b17308d Mon Sep 17 00:00:00 2001 From: Jed Davis Date: Tue, 30 Apr 2013 11:36:22 -0700 Subject: [PATCH] The null case of a nullable-poiner enum might not be nullary. Cases like `Either<@int,()>` have a null case with at most one value but a nonzero number of fields; if we misreport this, then bad things can happen inside of, for example, pattern matching. Closes #6117. --- src/librustc/middle/trans/adt.rs | 4 ++-- src/test/run-pass/issue-6117.rs | 16 ++++++++++++++++ 2 files changed, 18 insertions(+), 2 deletions(-) create mode 100644 src/test/run-pass/issue-6117.rs diff --git a/src/librustc/middle/trans/adt.rs b/src/librustc/middle/trans/adt.rs index b3e24fcc93951..0ee2a2c4cb149 100644 --- a/src/librustc/middle/trans/adt.rs +++ b/src/librustc/middle/trans/adt.rs @@ -409,8 +409,8 @@ pub fn num_args(r: &Repr, discr: int) -> uint { st.fields.len() - (if dtor { 1 } else { 0 }) } General(ref cases) => cases[discr as uint].fields.len() - 1, - NullablePointer{ nonnull: ref nonnull, nndiscr, _ } => { - if discr == nndiscr { nonnull.fields.len() } else { 0 } + NullablePointer{ nonnull: ref nonnull, nndiscr, nullfields: ref nullfields, _ } => { + if discr == nndiscr { nonnull.fields.len() } else { nullfields.len() } } } } diff --git a/src/test/run-pass/issue-6117.rs b/src/test/run-pass/issue-6117.rs new file mode 100644 index 0000000000000..73e9391f01683 --- /dev/null +++ b/src/test/run-pass/issue-6117.rs @@ -0,0 +1,16 @@ +// Copyright 2013 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +pub fn main() { + match Left(@17) { + Right(()) => {} + _ => {} + } +}