From 9191a7895574ec3aa5a9b84ce0008d91e32ccd6a Mon Sep 17 00:00:00 2001 From: Brian Anderson Date: Mon, 20 Jul 2015 10:41:52 -0700 Subject: [PATCH] Revert "Fix `missing_docs` lint for const and static." This reverts commit 00130cff99f88e13fec87378bdf476cfea6aa147. As mentioned in a regression report[1], this caused a notable amount of breakage. Because there's a plan to mitigate[2] this type of breakage, I'm reverting this until then. [1]: https://internals.rust-lang.org/t/new-crater-reports-1-1-stable-vs-beta-2015-07-10-and-nightly-2015-07-10/2358 [2]: https://github.com/rust-lang/rfcs/pull/1193 --- src/librustc_lint/builtin.rs | 2 -- src/test/compile-fail/lint-missing-doc.rs | 21 --------------------- 2 files changed, 23 deletions(-) diff --git a/src/librustc_lint/builtin.rs b/src/librustc_lint/builtin.rs index 1574080b313b5..467ceed60f1be 100644 --- a/src/librustc_lint/builtin.rs +++ b/src/librustc_lint/builtin.rs @@ -1610,8 +1610,6 @@ impl LintPass for MissingDoc { } return }, - ast::ItemConst(..) => "a constant", - ast::ItemStatic(..) => "a static", _ => return }; diff --git a/src/test/compile-fail/lint-missing-doc.rs b/src/test/compile-fail/lint-missing-doc.rs index 5501835886104..04db6c8c8f39c 100644 --- a/src/test/compile-fail/lint-missing-doc.rs +++ b/src/test/compile-fail/lint-missing-doc.rs @@ -149,27 +149,6 @@ pub enum PubBaz3 { #[doc(hidden)] pub fn baz() {} - -const FOO: u32 = 0; -/// dox -pub const FOO1: u32 = 0; -#[allow(missing_docs)] -pub const FOO2: u32 = 0; -#[doc(hidden)] -pub const FOO3: u32 = 0; -pub const FOO4: u32 = 0; //~ ERROR: missing documentation for a const - - -static BAR: u32 = 0; -/// dox -pub static BAR1: u32 = 0; -#[allow(missing_docs)] -pub static BAR2: u32 = 0; -#[doc(hidden)] -pub static BAR3: u32 = 0; -pub static BAR4: u32 = 0; //~ ERROR: missing documentation for a static - - mod internal_impl { /// dox pub fn documented() {}