From 1e180b809fed81b758b1ca743ba3af24504239ca Mon Sep 17 00:00:00 2001 From: Geoffrey Thomas Date: Fri, 22 May 2015 00:20:04 -0400 Subject: [PATCH 1/2] configure: Clarify error message about missing dependencies Took me a moment to figure out that the appropriate response to "need program file" was to install the program named "file", not to think "If I didn't need the program file, why would I be compiling things?". --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 9b8207ee91555..7850d7f03d8c5 100755 --- a/configure +++ b/configure @@ -33,8 +33,8 @@ need_ok() { need_cmd() { if command -v $1 >/dev/null 2>&1 - then msg "found program $1" - else err "need program $1" + then msg "found program '$1'" + else err "program '$1' is missing, please install it" fi } From dfacdcf25d31a32ccf8578f8af304b2d7f38f33d Mon Sep 17 00:00:00 2001 From: Geoffrey Thomas Date: Fri, 22 May 2015 00:25:01 -0400 Subject: [PATCH 2/2] configure: Fix printing of commands from `run` The `run` function passed its argument to `msg` via `"$@"`, but `msg` only printed its first argument. I think the intention was for `msg` to print all its arguments. (If not, `run` should only `msg "$1"`.) --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 7850d7f03d8c5..fe9e7cf7f7ac6 100755 --- a/configure +++ b/configure @@ -1,7 +1,7 @@ #!/bin/sh msg() { - echo "configure: $1" + echo "configure: $*" } step_msg() {