From 8b6592ef1a29360716e49545cff42d7103366b02 Mon Sep 17 00:00:00 2001 From: Davis Silverman Date: Sun, 16 Mar 2014 16:46:02 -0400 Subject: [PATCH] Asked if missing (), then asks about an anonymous function. Also added test. --- src/librustc/middle/typeck/check/mod.rs | 6 ++-- src/test/compile-fail/method-missing-call.rs | 34 ++++++++++++++++++++ 2 files changed, 38 insertions(+), 2 deletions(-) create mode 100644 src/test/compile-fail/method-missing-call.rs diff --git a/src/librustc/middle/typeck/check/mod.rs b/src/librustc/middle/typeck/check/mod.rs index 51efcb7d1c387..38a9119604b25 100644 --- a/src/librustc/middle/typeck/check/mod.rs +++ b/src/librustc/middle/typeck/check/mod.rs @@ -2317,11 +2317,13 @@ fn check_expr_with_unifier(fcx: @FnCtxt, fcx.type_error_message( expr.span, |actual| { - format!("attempted to take value of method `{}` on type `{}` \ - (try writing an anonymous function)", + format!("attempted to take value of method `{}` on type `{}`", token::get_name(field), actual) }, expr_t, None); + + tcx.sess.span_note(expr.span, + "maybe a missing `()` to call it? If not, try an anonymous function."); } None => { diff --git a/src/test/compile-fail/method-missing-call.rs b/src/test/compile-fail/method-missing-call.rs new file mode 100644 index 0000000000000..55a178af961ac --- /dev/null +++ b/src/test/compile-fail/method-missing-call.rs @@ -0,0 +1,34 @@ +// Copyright 2014 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +// Tests to make sure that parens are needed for method calls without arguments. +// outputs text to make sure either an anonymous function is provided or +// open-close '()' parens are given + + +struct Point { + x: int, + y: int +} +impl Point { + fn new() -> Point { + Point{x:0, y:0} + } + fn get_x(&self) -> int { + self.x + } +} + +fn main() { + let point: Point = Point::new(); + let px: int = point.get_x;//~ ERROR attempted to take value of method `get_x` on type `Point` + //~^ NOTE maybe a missing `()` to call it? If not, try an anonymous function. +} +