diff --git a/src/librustc/middle/region.rs b/src/librustc/middle/region.rs index 86de1399acbb9..232b35bb82afc 100644 --- a/src/librustc/middle/region.rs +++ b/src/librustc/middle/region.rs @@ -501,12 +501,17 @@ fn resolve_expr(visitor: &mut RegionResolutionVisitor, visitor.region_maps.mark_as_terminating_scope(otherwise.id); } - ast::ExprIf(_, then, None) => { + ast::ExprIf(expr, then, None) => { + visitor.region_maps.mark_as_terminating_scope(expr.id); visitor.region_maps.mark_as_terminating_scope(then.id); } - ast::ExprLoop(body, _) | - ast::ExprWhile(_, body) => { + ast::ExprLoop(body, _) => { + visitor.region_maps.mark_as_terminating_scope(body.id); + } + + ast::ExprWhile(expr, body) => { + visitor.region_maps.mark_as_terminating_scope(expr.id); visitor.region_maps.mark_as_terminating_scope(body.id); } diff --git a/src/test/run-pass/temporary-lifetime-for-conditions.rs b/src/test/run-pass/temporary-lifetime-for-conditions.rs new file mode 100644 index 0000000000000..1985970b1071c --- /dev/null +++ b/src/test/run-pass/temporary-lifetime-for-conditions.rs @@ -0,0 +1,50 @@ +// Copyright 2014 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + + +// This test verifies that temporaries created for `while`'s +// and `if` conditions are correctly cleaned up. + +struct Temporary; + +static mut DROPPED: int = 0; + +impl Drop for Temporary { + fn drop(&mut self) { + unsafe { DROPPED += 1; } + } +} + +impl Temporary { + fn do(&self) -> bool {true} +} + +fn borrow() -> ~Temporary { ~Temporary } + + +pub fn main() { + let mut i = 0; + + // This loop's condition + // should call `Temporary`'s + // `drop` 6 times. + while borrow().do() { + i += 1; + if i > 5 { + break; + } + } + + // This if condition should + // call it 1 time + if borrow().do() { + unsafe { assert_eq!(DROPPED, 7) } + } +}