Skip to content

enable ConstProp pass based on MIR opt level #98958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zeevm opened this issue Jul 5, 2022 · 2 comments
Closed

enable ConstProp pass based on MIR opt level #98958

zeevm opened this issue Jul 5, 2022 · 2 comments
Assignees
@zeevm
Labels
A-mir-opt Area: MIR optimizations

Comments

@zeevm
Copy link

zeevm commented Jul 5, 2022 •
edited by rustbot
Loading

ConstProp is currently always on, a leftover from when the pass was used for linting as well.

As the lint is now separated, ConstProp::is_enabled() should depend on opt level.
@zeevm
Copy link
Author

zeevm commented Jul 5, 2022

@rustbot claim

@zeevm
Copy link
Author

zeevm commented Jul 5, 2022

@rustbot label A-mir-opt

@rustbot rustbot added the A-mir-opt Area: MIR optimizations label Jul 5, 2022
@zeevm zeevm mentioned this issue Jul 6, 2022
Merged
@zeevm zeevm closed this as completed Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zeevm zeevm

Labels
A-mir-opt Area: MIR optimizations
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zeevm @rustbot