Skip to content

tidy is not good at detecting untracked files #78815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
robinmoussu opened this issue Nov 6, 2020 · 3 comments
Closed

tidy is not good at detecting untracked files #78815

robinmoussu opened this issue Nov 6, 2020 · 3 comments
Labels
A-contributor-roadblock Area: Makes things more difficult for new or seasoned contributors to Rust A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@robinmoussu
Copy link

When running x.py test, I got a bazillion errors (434 to be more precise). I think that all those errors comes from .js files. Most (all?) of them being:

missing trailing newline
line longer than 100 chars

Is this "expected"? Because of those errors, the command finishes with an error code (exit code: 1).

@robinmoussu robinmoussu added the C-bug Category: This is a bug. label Nov 6, 2020
@jyn514
Copy link
Member

jyn514 commented Nov 6, 2020

@robinmoussu that's from tidy - do you have untracked files maybe? tidy tries to avoid untracked files but it's not very good at it.

@jyn514 jyn514 added the A-testsuite Area: The testsuite used to check the correctness of rustc label Nov 6, 2020
@robinmoussu
Copy link
Author

I was effectively that. I generated the doc for rustc_parse and rustc_lexer by running cargo doc directly in those folder. Even a cargo clean didn't clear the target directory, and I didn't noticed it.

@jyn514 jyn514 changed the title ./x.py test yields many errors tidy is not good at detecting untracked files Nov 6, 2020
@jyn514 jyn514 added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-contributor-roadblock Area: Makes things more difficult for new or seasoned contributors to Rust C-enhancement Category: An issue proposing an enhancement or a PR with one. and removed C-bug Category: This is a bug. labels Nov 6, 2020
@arora-aman
Copy link
Member

Duplicate of #75582

@jyn514 jyn514 closed this as completed Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-contributor-roadblock Area: Makes things more difficult for new or seasoned contributors to Rust A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

No branches or pull requests

3 participants