Skip to content

MIR dumps should use "crate_name." as a prefix instead of "rustc.". #70767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eddyb opened this issue Apr 4, 2020 · 1 comment · Fixed by #74837
Closed

MIR dumps should use "crate_name." as a prefix instead of "rustc.". #70767

eddyb opened this issue Apr 4, 2020 · 1 comment · Fixed by #74837
Labels
A-mir-opt Area: MIR optimizations A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@eddyb
Copy link
Member

eddyb commented Apr 4, 2020

rustc.main.SimplifyCfg-initial.after.mir (in src/test/mir-opt/basic_assignment) is the kind of file name we have right now, but if we used the crate name instead at the start, we'd have:
basic_assignment.main.SimplifyCfg-initial.after.mir.

Besides being more useful when dumping a bunch of stuff outside of tests, it would let us remove the directory nesting, so that file could just be in src/test/mir-opt, right next to basic_assignment.rs.

cc @rust-lang/wg-mir-opt

@eddyb eddyb added A-testsuite Area: The testsuite used to check the correctness of rustc A-mir-opt Area: MIR optimizations labels Apr 4, 2020
@eddyb
Copy link
Member Author

eddyb commented Apr 4, 2020

Also, instead of 32/64 bit directories we could just add that information in the file names just before the extension, i.e. files could end in .32.diff and .{before,after}.32.mir.

@jonas-schievink jonas-schievink added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 4, 2020
@JohnTitor JohnTitor added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Apr 12, 2020
@xldenis xldenis mentioned this issue Jul 28, 2020
@bors bors closed this as completed in 8611e52 Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-mir-opt Area: MIR optimizations A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants