Skip to content

Suggest installing rustc-dev when rustc_* crate can't be found on nightly #70157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bjorn3 opened this issue Mar 19, 2020 · 6 comments
Closed
Assignees
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@bjorn3
Copy link
Member

bjorn3 commented Mar 19, 2020

The current error message can't find crate ... is not very helpful. Suggesting installation of rustc-dev would avoid things like rust-lang/miri#1241 (comment).

@jonas-schievink jonas-schievink added A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 19, 2020
@pierwill
Copy link
Member

@rustbot claim

@bjorn3
Copy link
Member Author

bjorn3 commented Oct 15, 2021

Looks like this is already implemented:

} else if crate_name.as_str().starts_with("rustc_") {
err.help(
"maybe you need to install the missing components with: \
`rustup component add rust-src rustc-dev llvm-tools-preview`",
);
}

@bjorn3
Copy link
Member Author

bjorn3 commented Oct 15, 2021

This was done in #88830.

@bjorn3 bjorn3 closed this as completed Oct 15, 2021
@pierwill
Copy link
Member

pierwill commented Oct 15, 2021

Is this restricted to nightly builds?

} else if crate_name.as_str().starts_with("rustc_") {

@pierwill
Copy link
Member

Does the existing code need else if crate_name.as_str().starts_with("rustc_") && sess.is_nightly_build()?

@bjorn3
Copy link
Member Author

bjorn3 commented Oct 15, 2021

Looks like it isn't restricted to nightly builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants