Skip to content

Fix trait_ref_to_existential as trait aliases is stabilized #66420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
estebank opened this issue Nov 14, 2019 · 0 comments
Open

Fix trait_ref_to_existential as trait aliases is stabilized #66420

estebank opened this issue Nov 14, 2019 · 0 comments
Labels
A-dyn-compatibility Area: Dyn compatibility (formerly: object safety) A-dyn-trait Area: trait objects, vtable layout C-bug Category: This is a bug. F-trait_alias `#![feature(trait_alias)]` requires-nightly This issue requires a nightly compiler in some way. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-types Relevant to the types team, which will review and decide on the PR/issue.

Comments

@estebank
Copy link
Contributor

#66392 (comment)

There appears to be a missing filter on top of expand_trait_aliases, which picks up non-supertraits where clauses - but also, the object safety completely ignores trait aliases, which could be object safety hazards. We now use delay_span_bug there to avoid an ICE in stable even when the feature is disabled.
@estebank estebank added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. F-trait_alias `#![feature(trait_alias)]` labels Nov 14, 2019
@estebank estebank mentioned this issue Nov 14, 2019
Merged
@Centril Centril added the requires-nightly This issue requires a nightly compiler in some way. label Nov 14, 2019
@fmease fmease added T-types Relevant to the types team, which will review and decide on the PR/issue. A-dyn-trait Area: trait objects, vtable layout A-dyn-compatibility Area: Dyn compatibility (formerly: object safety) C-bug Category: This is a bug. labels Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-dyn-compatibility Area: Dyn compatibility (formerly: object safety) A-dyn-trait Area: trait objects, vtable layout C-bug Category: This is a bug. F-trait_alias `#![feature(trait_alias)]` requires-nightly This issue requires a nightly compiler in some way. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-types Relevant to the types team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Centril @estebank @fmease