-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Replace macro impls in libstd/num/strconv.rs with generic impls #4955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
As the bug description says, this is blocked by revisions to the numeric traits, which I think are being tracked in Issue #4819. |
Also, the bug might become irrelevant because I'm kinda working on re-replacing that central trait with macro-generated specialized versions for ints, uints and floats. But that hasn't landed yet, so for now this is still relevant. |
In theory the change to make is to write something like |
Triage: the macros are still there; this is part of #6220. |
Triage: Updated the title and description |
@bjz do you still plan to work on this (and to hide |
Yes, I do, sorry for the delay. |
There are no numeric traits now and this won't happen. |
The impl macros in libstd/num/strconv.rs should get replaced by two generic impls for the not yet existing
Integral
andFloating
traits once those traits exists, and once the compiler supports multiple generic impls against different traits.The text was updated successfully, but these errors were encountered: