Skip to content

Nightly documentation's std::vec's source link does not work #28302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
e00E opened this issue Sep 8, 2015 · 7 comments
Closed

Nightly documentation's std::vec's source link does not work #28302

e00E opened this issue Sep 8, 2015 · 7 comments
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@e00E
Copy link
Contributor

e00E commented Sep 8, 2015

The source link on the vec page https://doc.rust-lang.org/nightly/std/vec/index.html leads to https://doc.rust-lang.org/nightly/core_collections/vec/?gotosrc=24157 which is just a Not Found page. I randomly clicked source on other pages and they seem to work.

@steveklabnik steveklabnik added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Sep 8, 2015
@nfallen
Copy link

nfallen commented Sep 11, 2015

I will fix this!

@nfallen
Copy link

nfallen commented Sep 11, 2015

The link is going to core_collections/vec when it should just be going to collections/vec. I can't push a change to the index.html file because it is in the gitignore so I'm assuming the link is generated somewhere else. I'm new to the repo, so does anyone else know where the link is generated?

@Gankra
Copy link
Contributor

Gankra commented Sep 11, 2015

@nfallen yes all of these pages are generated from the code source

This is a bug in rustdoc, which generates these links: https://github.com/rust-lang/rust/tree/master/src/librustdoc

I'm not sure if there's a specific issue for this, but rustdoc has a lot of bugs, and needs a lot of love

@nfallen
Copy link

nfallen commented Sep 11, 2015

thank you @gankro I will look into the rustdoc bug

@Gankra
Copy link
Contributor

Gankra commented Sep 11, 2015

@alexcrichton probably knows the most about our current design

@mitaa
Copy link
Contributor

mitaa commented Feb 12, 2016

Seems fixed?

@nfallen

The link is going to core_collections/vec when it should just be going to collections/vec

Judging from that this seems to have been the same problem as #30109 and #30198

@steveklabnik
Copy link
Member

This is in fact fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

5 participants