Skip to content

Don't require Valgrind for tests by default #20580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Manishearth opened this issue Jan 5, 2015 · 1 comment
Closed

Don't require Valgrind for tests by default #20580

Manishearth opened this issue Jan 5, 2015 · 1 comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc

Comments

@Manishearth
Copy link
Member

$ make check-stage2-pretty-rpass
cfg: build triple x86_64-unknown-linux-gnu
cfg: host triples x86_64-unknown-linux-gnu
cfg: target triples x86_64-unknown-linux-gnu
cfg: enabling more debugging (CFG_ENABLE_DEBUG)
cfg: host for x86_64-unknown-linux-gnu is x86_64
cfg: os for x86_64-unknown-linux-gnu is unknown-linux-gnu
cfg: good valgrind for x86_64-unknown-linux-gnu is 1
cfg: using CC=gcc (CFG_CC)
cfg: enabling valgrind run-pass tests (CFG_ENABLE_VALGRIND_RPASS)
cfg: no pandoc found, omitting PDF and EPUB docs
cfg: including test rules
cfg: valgrind-path set to 
cfg: valgrind-path set to 
cfg: valgrind-path set to 
cfg: valgrind-path set to 
cfg: javac not available, skipping lexer test...
rustc: x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/bin/compiletest
cp: x86_64-unknown-linux-gnu/stage2/bin/compiletest
run pretty-rpass [x86_64-unknown-linux-gnu]: x86_64-unknown-linux-gnu/stage2/bin/compiletest
thread '<main>' panicked at 'Can't find Valgrind to run Valgrind tests', /home/manishearth/Mozilla/rust/src/compiletest/compiletest.rs:45
make: *** [tmp/check-stage2-T-x86_64-unknown-linux-gnu-H-x86_64-unknown-linux-gnu-pretty-rpass.ok] Error 101

We don't need Valgrind for rpass-pretty, we probably shouldn't crash on that.

@kmcallister kmcallister added the A-testsuite Area: The testsuite used to check the correctness of rustc label Jan 5, 2015
@brson
Copy link
Contributor

brson commented Jan 7, 2015

Dupe of #18588

@brson brson closed this as completed Jan 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc
Projects
None yet
Development

No branches or pull requests

3 participants