Skip to content

Dead code in Bitv undetected by Lint #16737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Gankra opened this issue Aug 24, 2014 · 5 comments
Closed

Dead code in Bitv undetected by Lint #16737

Gankra opened this issue Aug 24, 2014 · 5 comments
Labels
A-lints Area: Lints (warnings about flaws in source code) such as unused_mut.

Comments

@Gankra
Copy link
Contributor

Gankra commented Aug 24, 2014

The two structs and enum found here appear to be private to the module, and yet are never referenced anywhere in the module.

Yet, rust builds without a complaint.
@Gankra
Copy link
Contributor Author

Gankra commented Aug 24, 2014

(Not removing the dead code for the moment so that it can be investigated)

@huonw
Copy link
Member

huonw commented Aug 24, 2014

I don't have a rustc with me now, but I'm guessing the derived Clone implementation is counting as a use.

@Gankra
Copy link
Contributor Author

Gankra commented Nov 22, 2014

Not sure what to do with this issue anymore.

@sanxiyn sanxiyn added the A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. label Jan 25, 2015
@sanxiyn
Copy link
Member

sanxiyn commented Nov 9, 2015

Is this still a problem? Deriving Clone doesn't count as a use since #25961.

@Gankra
Copy link
Contributor Author

Gankra commented Nov 9, 2015

SGTM

@Gankra Gankra closed this as completed Nov 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-lints Area: Lints (warnings about flaws in source code) such as unused_mut.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sanxiyn @Gankra @huonw