Skip to content

compiletest: warn on //[rev_name]@ ... #137146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jieyouxu opened this issue Feb 16, 2025 · 2 comments
Closed

compiletest: warn on //[rev_name]@ ... #137146

jieyouxu opened this issue Feb 16, 2025 · 2 comments
Labels
A-compiletest Area: The compiletest test runner C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jieyouxu
Copy link
Member

The correct form is

//@[rev_name]

but it's easy to accidentally write

//[rev_name]@

because the error annotation form is...

//[rev_name]~ ERROR

compiletest should probably warn on the incorrect revision form.
@jieyouxu jieyouxu added A-compiletest Area: The compiletest test runner C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Feb 16, 2025
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Feb 16, 2025
@jieyouxu jieyouxu removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Feb 16, 2025
@jieyouxu jieyouxu mentioned this issue Feb 16, 2025
Merged
@fmease
Copy link
Member

fmease commented Feb 16, 2025

Dupe of #130815 :P

@jieyouxu
Copy link
Member Author

I have absolutely zero recollection on having commented on that

@jieyouxu jieyouxu closed this as not planned Won't fix, can't repro, duplicate, stale Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-compiletest Area: The compiletest test runner C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
compiletest maintenance and improvements
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fmease @jieyouxu @rustbot