---

yaml
---
r: 149096
b: refs/heads/try2
c: de6ed9c
h: refs/heads/master
v: v3

Author: SimonSapin

[refs]

@@ -5,7 +5,7 @@ refs/heads/snap-stage3: 78a7676898d9f80ab540c6df5d4c9ce35bb50463
 refs/heads/try: 519addf6277dbafccbb4159db4b710c37eaa2ec5
 refs/tags/release-0.1: 1f5c5126e96c79d22cb7862f75304136e204f105
 refs/heads/ndm: f3868061cd7988080c30d6d5bf352a5a5fe2460b
-refs/heads/try2: be3cbcb4314570cd974d349b92e761eaef5078fb
+refs/heads/try2: de6ed9c0cee2680e89ccb203be97fedc47729f54
 refs/heads/dist-snap: ba4081a5a8573875fed17545846f6f6902c8ba8d
 refs/tags/release-0.2: c870d2dffb391e14efb05aa27898f1f6333a9596
 refs/tags/release-0.3: b5f0d0f648d9a6153664837026ba1be43d3e2503

branches/try2/Makefile.in

@@ -140,8 +140,7 @@ endif
 # snapshot will be generated with a statically linked rustc so we only have to
 # worry about the distribution of one file (with its native dynamic
 # dependencies)
-#
-# NOTE: after a snapshot (stage0), put this on stage0 as well
+RUSTFLAGS_STAGE0 += -Z prefer-dynamic
 RUSTFLAGS_STAGE1 += -C prefer-dynamic
 
 # platform-specific auto-configuration

branches/try2/mk/tests.mk

@@ -34,7 +34,7 @@ ifdef TESTNAME
   TESTARGS += $(TESTNAME)
 endif
 
-ifdef CHECK_IGNORED
+ifdef CHECK_XFAILS
   TESTARGS += --ignored
 endif
 

branches/try2/src/compiletest/compiletest.rs

@@ -61,7 +61,7 @@ pub fn parse_config(args: ~[~str]) -> config {
           reqopt("", "stage-id", "the target-stage identifier", "stageN-TARGET"),
           reqopt("", "mode", "which sort of compile tests to run",
                  "(compile-fail|run-fail|run-pass|pretty|debug-info)"),
-          optflag("", "ignored", "run tests marked as ignored"),
+          optflag("", "ignored", "run tests marked as ignored / xfailed"),
           optopt("", "runtool", "supervisor program to run tests under \
                                  (eg. emulator, valgrind)", "PROGRAM"),
           optopt("", "rustcflags", "flags to pass to rustc", "FLAGS"),

branches/try2/src/compiletest/header.rs

@@ -95,19 +95,19 @@ pub fn load_props(testfile: &Path) -> TestProps {
 }
 
 pub fn is_test_ignored(config: &config, testfile: &Path) -> bool {
-    fn ignore_target(config: &config) -> ~str {
-        ~"ignore-" + util::get_os(config.target)
+    fn xfail_target(config: &config) -> ~str {
+        ~"xfail-" + util::get_os(config.target)
     }
-    fn ignore_stage(config: &config) -> ~str {
-        ~"ignore-" + config.stage_id.split('-').next().unwrap()
+    fn xfail_stage(config: &config) -> ~str {
+        ~"xfail-" + config.stage_id.split('-').next().unwrap()
     }
 
     let val = iter_header(testfile, |ln| {
-        if parse_name_directive(ln, "ignore-test") { false }
-        else if parse_name_directive(ln, ignore_target(config)) { false }
-        else if parse_name_directive(ln, ignore_stage(config)) { false }
+        if parse_name_directive(ln, "xfail-test") { false }
+        else if parse_name_directive(ln, xfail_target(config)) { false }
+        else if parse_name_directive(ln, xfail_stage(config)) { false }
         else if config.mode == common::mode_pretty &&
-            parse_name_directive(ln, "ignore-pretty") { false }
+            parse_name_directive(ln, "xfail-pretty") { false }
         else { true }
     });
 

branches/try2/src/doc/tutorial.md

@@ -2679,24 +2679,25 @@ manual.
 
 ## Files and modules
 
-One important aspect of Rust's module system is that source files and modules are not the same thing. You define a module hierarchy, populate it with all your definitions, define visibility, maybe put in a `fn main()`, and that's it.
+One important aspect about Rusts module system is that source files are not important:
+You define a module hierarchy, populate it with all your definitions, define visibility,
+maybe put in a `fn main()`, and that's it: No need to think about source files.
 
-The only file that's relevant when compiling is the one that contains the body
-of your crate root, and it's only relevant because you have to pass that file
-to `rustc` to compile your crate.
+The only file that's relevant is the one that contains the body of your crate root,
+and it's only relevant because you have to pass that file to `rustc` to compile your crate.
 
-In principle, that's all you need: You can write any Rust program as one giant source file that contains your
-crate root and everything else in `mod ... { ... }` declarations.
+And in principle, that's all you need: You can write any Rust program as one giant source file that contains your
+crate root and everything below it in `mod ... { ... }` declarations.
 
-However, in practice you usually want to split up your code into multiple
-source files to make it more manageable. Rust allows you to move the body of
-any module into its own source file. If you declare a module without its body,
-like `mod foo;`, the compiler will look for the files `foo.rs` and `foo/mod.rs`
-inside some directory (usually the same as of the source file containing the
-`mod foo;` declaration). If it finds either, it uses the content of that file
-as the body of the module. If it finds both, that's a compile error.
+However, in practice you usually want to split you code up into multiple source files to make it more manageable.
+In order to do that, Rust allows you to move the body of any module into it's own source file, which works like this:
 
-To move the content of `mod farm` into its own file, you can write:
+If you declare a module without its body, like `mod foo;`, the compiler will look for the
+files `foo.rs` and `foo/mod.rs` inside some directory (usually the same as of the source file containing
+the `mod foo;`). If it finds either, it uses the content of that file as the body of the module.
+If it finds both, that's a compile error.
+
+So, if we want to move the content of `mod farm` into it's own file, it would look like this:
 
 ~~~~ {.ignore}
 // `main.rs` - contains body of the crate root
@@ -2721,13 +2722,17 @@ pub mod barn {
 
 In short, `mod foo;` is just syntactic sugar for `mod foo { /* content of <...>/foo.rs or <...>/foo/mod.rs */ }`.
 
-This also means that having two or more identical `mod foo;` declarations somewhere in your crate hierarchy is generally a bad idea,
-just like copy-and-paste-ing a module into multiple places is a bad idea.
+This also means that having two or more identical `mod foo;` somewhere
+in your crate hierarchy is generally a bad idea,
+just like copy-and-paste-ing a module into two or more places is one.
 Both will result in duplicate and mutually incompatible definitions.
 
-When `rustc` resolves these module declarations, it starts by looking in the
-parent directory of the file containing the `mod foo` declaration. For example,
-given a file with the module body:
+The directory the compiler looks in for those two files is determined by starting with
+the same directory as the source file that contains the `mod foo;` declaration, and concatenating to that a
+path equivalent to the relative path of all nested `mod { ... }` declarations the `mod foo;`
+is contained in, if any.
+
+For example, given a file with this module body:
 
 ~~~ {.ignore}
 // `src/main.rs`
@@ -2740,7 +2745,7 @@ mod animals {
 }
 ~~~
 
-The compiler will look for these files, in this order:
+The compiler would then try all these files:
 
 ~~~ {.notrust}
 src/plants.rs
@@ -2753,9 +2758,9 @@ src/animals/mammals/humans.rs
 src/animals/mammals/humans/mod.rs
 ~~~
 
-Keep in mind that identical module hierarchies can still lead to different path
-lookups depending on how and where you've moved a module body to its own file.
-For example, if you move the `animals` module into its own file:
+Keep in mind that identical module hierachies can still lead to different path lookups
+depending on how and where you've moved a module body to its own file.
+For example, if we move the `animals` module above into its own file...
 
 ~~~ {.ignore}
 // `src/main.rs`
@@ -2771,21 +2776,21 @@ mod mammals {
 }
 ~~~
 
-...then the source files of `mod animals`'s submodules can either be in the same directory as the animals source file or in a subdirectory of its directory. If the animals file is `src/animals.rs`, `rustc` will look for:
+...then the source files of `mod animals`'s submodules can
+either be placed right next to that of its parents, or in a subdirectory if `animals` source file is:
 
 ~~~ {.notrust}
-src/animals.rs
+src/plants.rs
+src/plants/mod.rs
+
+src/animals.rs - if file sits next to that of parent module's:
     src/fish.rs
     src/fish/mod.rs
 
     src/mammals/humans.rs
     src/mammals/humans/mod.rs
-~~
-
-If the animals file is `src/animals/mod.rs`, `rustc` will look for:
 
-~~ {.notrust}
-src/animals/mod.rs
+src/animals/mod.rs - if file is in it's own subdirectory:
     src/animals/fish.rs
     src/animals/fish/mod.rs
 
@@ -2794,11 +2799,11 @@ src/animals/mod.rs
 
 ~~~
 
-These rules allow you to write small modules consisting of single source files which can live in the same directory as well as large modules which group submodule source files in subdirectories.
+These rules allow you to have both small modules that only need
+to consist of one source file each and can be conveniently placed right next to each other,
+and big complicated modules that group the source files of submodules in subdirectories.
 
-If you need to override where `rustc` will look for the file containing a
-module's source code, use the `path` compiler directive. For example, to load a
-`classified` module from a different file:
+If you need to circumvent the defaults, you can also overwrite the path a `mod foo;` would take:
 
 ~~~ {.ignore}
 #[path="../../area51/alien.rs"]

branches/try2/src/etc/combine-tests.py

@@ -1,4 +1,4 @@
-# Copyright 2011-2014 The Rust Project Developers. See the COPYRIGHT
+# Copyright 2011-2013 The Rust Project Developers. See the COPYRIGHT
 # file at the top-level directory of this distribution and at
 # http://rust-lang.org/COPYRIGHT.
 #
@@ -36,9 +36,9 @@ def scrub(b):
             t.startswith(".") or t.startswith("#") or t.startswith("~")):
         f = codecs.open(os.path.join(run_pass, t), "r", "utf8")
         s = f.read()
-        if not ("ignore-test" in s or
-                "ignore-fast" in s or
-                "ignore-win32" in s):
+        if not ("xfail-test" in s or
+                "xfail-fast" in s or
+                "xfail-win32" in s):
             if not "pub fn main" in s and "fn main" in s:
                 print("Warning: no public entry point in " + t)
             stage2_tests.append(t)

branches/try2/src/etc/extract-tests.py

@@ -99,7 +99,7 @@ def extract_code_fragments(dest_dir, lines):
         block.appendleft(OUTPUT_BLOCK_HEADER)
 
         if "ignore" in tags:
-            block.appendleft("//ignore-test\n")
+            block.appendleft("//xfail-test\n")
         elif "should_fail" in tags:
             block.appendleft("//should-fail\n")
 

branches/try2/src/etc/licenseck.py

@@ -1,4 +1,4 @@
-# Copyright 2013-2014 The Rust Project Developers. See the COPYRIGHT
+# Copyright 2013 The Rust Project Developers. See the COPYRIGHT
 # file at the top-level directory of this distribution and at
 # http://rust-lang.org/COPYRIGHT.
 #
@@ -52,12 +52,12 @@ def check_license(name, contents):
 
     # Xfail check
     firstlineish = contents[:100]
-    if firstlineish.find("ignore-license") != -1:
+    if firstlineish.find("xfail-license") != -1:
         return True
 
     # License check
     boilerplate = contents[:500]
     if (boilerplate.find(license1) == -1 or boilerplate.find(license2) == -1) and \
        (boilerplate.find(license3) == -1 or boilerplate.find(license4) == -1):
         return False
-    return True
+    return True

branches/try2/src/etc/tidy.py

@@ -14,9 +14,9 @@
 
 err=0
 cols=100
-cr_flag="ignore-tidy-cr"
-tab_flag="ignore-tidy-tab"
-linelength_flag="ignore-tidy-linelength"
+cr_flag="xfail-tidy-cr"
+tab_flag="xfail-tidy-tab"
+linelength_flag="xfail-tidy-linelength"
 
 # Be careful to support Python 2.4, 2.6, and 3.x here!
 config_proc=subprocess.Popen([ "git", "config", "core.autocrlf" ],

branches/try2/src/libgreen/sched.rs

@@ -1,4 +1,4 @@
-// Copyright 2013-2014 The Rust Project Developers. See the COPYRIGHT
+// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
 // file at the top-level directory of this distribution and at
 // http://rust-lang.org/COPYRIGHT.
 //
@@ -1364,7 +1364,7 @@ mod test {
         });
     }
 
-    // FIXME: #9407: ignore-test
+    // FIXME: #9407: xfail-test
     #[ignore]
     #[test]
     fn dont_starve_1() {

branches/try2/src/libstd/iter.rs

@@ -59,7 +59,7 @@ This `for` loop syntax can be applied to any iterator over any type.
 ## Iteration protocol and more
 
 More detailed information about iterators can be found in the [container
-tutorial](http://static.rust-lang.org/doc/master/tutorial-container.html) with
+guide](http://static.rust-lang.org/doc/master/guide-container.html) with
 the rest of the rust manuals.
 
 */

branches/try2/src/libsyntax/parse/parser.rs

@@ -1799,7 +1799,7 @@ impl Parser {
         } else if self.eat_keyword(keywords::Self) {
             let path = ast_util::ident_to_path(mk_sp(lo, hi), special_idents::self_);
             ex = ExprPath(path);
-            hi = self.last_span.hi;
+            hi = self.span.hi;
         } else if self.eat_keyword(keywords::If) {
             return self.parse_if_expr();
         } else if self.eat_keyword(keywords::For) {
@@ -1934,7 +1934,7 @@ impl Parser {
                                          &[token::COMMA], &[token::RBRACE]);
                     }
 
-                    hi = self.span.hi;
+                    hi = pth.span.hi;
                     self.expect(&token::RBRACE);
                     ex = ExprStruct(pth, fields, base);
                     return self.mk_expr(lo, hi, ex);

branches/try2/src/test/auxiliary/crateresolve7x.rs

@@ -1,4 +1,4 @@
-// Copyright 2012-2014 The Rust Project Developers. See the COPYRIGHT
+// Copyright 2012 The Rust Project Developers. See the COPYRIGHT
 // file at the top-level directory of this distribution and at
 // http://rust-lang.org/COPYRIGHT.
 //
@@ -8,7 +8,7 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-// ignore-fast
+// xfail-fast
 // aux-build:crateresolve_calories-1.rs
 // aux-build:crateresolve_calories-2.rs
 

branches/try2/src/test/auxiliary/issue-2414-b.rs

@@ -1,4 +1,4 @@
-// Copyright 2012-2014 The Rust Project Developers. See the COPYRIGHT
+// Copyright 2012 The Rust Project Developers. See the COPYRIGHT
 // file at the top-level directory of this distribution and at
 // http://rust-lang.org/COPYRIGHT.
 //
@@ -8,7 +8,7 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-// ignore-fast
+// xfail-fast
 
 #[crate_id="b#0.1"];
 #[crate_type = "lib"];

branches/try2/src/test/auxiliary/issue-9906.rs

@@ -1,4 +1,4 @@
-// Copyright 2013-2014 The Rust Project Developers. See the COPYRIGHT
+// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
 // file at the top-level directory of this distribution and at
 // http://rust-lang.org/COPYRIGHT.
 //
@@ -8,7 +8,7 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-// ignore-fast windows doesn't like extern mod
+// xfail-fast windows doesn't like extern mod
 // aux-build:issue-9906.rs
 
 pub use other::FooBar;

branches/try2/src/test/bench/core-set.rs

@@ -1,6 +1,6 @@
-// ignore-pretty
+// xfail-pretty
 
-// Copyright 2013-2014 The Rust Project Developers. See the COPYRIGHT
+// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
 // file at the top-level directory of this distribution and at
 // http://rust-lang.org/COPYRIGHT.
 //

branches/try2/src/test/bench/shootout-fannkuch-redux.rs

@@ -8,7 +8,7 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-// ignore-test reading from os::args()[1] - bogus!
+// xfail-test reading from os::args()[1] - bogus!
 
 use std::from_str::FromStr;
 use std::os;

branches/try2/src/test/bench/shootout-fasta-redux.rs

@@ -8,7 +8,7 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-// ignore-test reading from os::args()[1] - bogus!
+// xfail-test reading from os::args()[1] - bogus!
 
 use std::cast::transmute;
 use std::from_str::FromStr;

branches/try2/src/test/bench/shootout-k-nucleotide-pipes.rs

@@ -1,4 +1,4 @@
-// Copyright 2012-2014 The Rust Project Developers. See the COPYRIGHT
+// Copyright 2012 The Rust Project Developers. See the COPYRIGHT
 // file at the top-level directory of this distribution and at
 // http://rust-lang.org/COPYRIGHT.
 //
@@ -8,9 +8,9 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-// ignore-android: FIXME(#10393)
+// xfail-android: FIXME(#10393)
 
-// ignore-pretty the `let to_child` line gets an extra newline
+// xfail-pretty the `let to_child` line gets an extra newline
 // multi tasking k-nucleotide
 
 extern mod extra;

branches/try2/src/test/bench/shootout-k-nucleotide.rs

@@ -8,7 +8,7 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-// ignore-test
+// xfail-test
 
 extern mod extra;