Skip to content

Commit dedf6fc

Browse files
committed
rustdoc: clean up CSS/DOM for deprecation warnings
1 parent 8ab71ab commit dedf6fc

File tree

3 files changed

+12
-24
lines changed

3 files changed

+12
-24
lines changed

src/librustdoc/html/markdown.rs

+8-11
Original file line numberDiff line numberDiff line change
@@ -111,14 +111,9 @@ pub(crate) struct MarkdownWithToc<'a>(
111111
pub(crate) Edition,
112112
pub(crate) &'a Option<Playground>,
113113
);
114-
/// A tuple struct like `Markdown` that renders the markdown escaping HTML tags.
115-
pub(crate) struct MarkdownHtml<'a>(
116-
pub(crate) &'a str,
117-
pub(crate) &'a mut IdMap,
118-
pub(crate) ErrorCodes,
119-
pub(crate) Edition,
120-
pub(crate) &'a Option<Playground>,
121-
);
114+
/// A tuple struct like `Markdown` that renders the markdown escaping HTML tags
115+
/// and includes no paragraph tags.
116+
pub(crate) struct MarkdownItemInfo<'a>(pub(crate) &'a str, pub(crate) &'a mut IdMap);
122117
/// A tuple struct like `Markdown` that renders only the first paragraph.
123118
pub(crate) struct MarkdownSummaryLine<'a>(pub &'a str, pub &'a [RenderedLink]);
124119

@@ -1072,9 +1067,9 @@ impl MarkdownWithToc<'_> {
10721067
}
10731068
}
10741069

1075-
impl MarkdownHtml<'_> {
1070+
impl MarkdownItemInfo<'_> {
10761071
pub(crate) fn into_string(self) -> String {
1077-
let MarkdownHtml(md, ids, codes, edition, playground) = self;
1072+
let MarkdownItemInfo(md, ids) = self;
10781073

10791074
// This is actually common enough to special-case
10801075
if md.is_empty() {
@@ -1093,7 +1088,9 @@ impl MarkdownHtml<'_> {
10931088
let p = HeadingLinks::new(p, None, ids, HeadingOffset::H1);
10941089
let p = Footnotes::new(p);
10951090
let p = TableWrapper::new(p.map(|(ev, _)| ev));
1096-
let p = CodeBlocks::new(p, codes, edition, playground);
1091+
let p = p.filter(|event| {
1092+
!matches!(event, Event::Start(Tag::Paragraph) | Event::End(Tag::Paragraph))
1093+
});
10971094
html::push_html(&mut s, p);
10981095

10991096
s

src/librustdoc/html/render/mod.rs

+4-9
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,9 @@ use crate::html::format::{
7474
PrintWithSpace,
7575
};
7676
use crate::html::highlight;
77-
use crate::html::markdown::{HeadingOffset, IdMap, Markdown, MarkdownHtml, MarkdownSummaryLine};
77+
use crate::html::markdown::{
78+
HeadingOffset, IdMap, Markdown, MarkdownItemInfo, MarkdownSummaryLine,
79+
};
7880
use crate::html::sources;
7981
use crate::html::static_files::SCRAPE_EXAMPLES_HELP_MD;
8082
use crate::scrape_examples::{CallData, CallLocation};
@@ -582,7 +584,6 @@ fn short_item_info(
582584
parent: Option<&clean::Item>,
583585
) -> Vec<String> {
584586
let mut extra_info = vec![];
585-
let error_codes = cx.shared.codes;
586587

587588
if let Some(depr @ Deprecation { note, since, is_since_rustc_version: _, suggestion: _ }) =
588589
item.deprecation(cx.tcx())
@@ -606,13 +607,7 @@ fn short_item_info(
606607

607608
if let Some(note) = note {
608609
let note = note.as_str();
609-
let html = MarkdownHtml(
610-
note,
611-
&mut cx.id_map,
612-
error_codes,
613-
cx.shared.edition(),
614-
&cx.shared.playground,
615-
);
610+
let html = MarkdownItemInfo(note, &mut cx.id_map);
616611
message.push_str(&format!(": {}", html.into_string()));
617612
}
618613
extra_info.push(format!(

src/librustdoc/html/static/css/rustdoc.css

-4
Original file line numberDiff line numberDiff line change
@@ -1078,10 +1078,6 @@ so that we can apply CSS-filters to change the arrow color in themes */
10781078
font-size: 0.875rem;
10791079
font-weight: normal;
10801080
}
1081-
.stab p {
1082-
display: inline;
1083-
margin: 0;
1084-
}
10851081

10861082
.stab .emoji {
10871083
font-size: 1.25rem;

0 commit comments

Comments
 (0)