Auto merge of #64673 - Mark-Simulacrum:opt-match-ck, r=<try>

Optimize match checking to avoid layout queries

In code with large, single-value match statements, we were previously
spending a lot of time running layout_of for the primitive types
(integers, chars) -- which is essentially useless. This optimizes the
code to avoid those query calls by directly obtaining the size for these
types, when possible.

We fallback to the (slower) previous code if that fails, so this is not
a behavior change.

r? @Centril who I believe knows this code enough, but if not feel free to re-assign

Author: bors

src/librustc_mir/hair/pattern/_match.rs

@@ -859,7 +859,27 @@ impl<'tcx> IntRange<'tcx> {
             }
             ConstantValue(val) if is_integral(val.ty) => {
                 let ty = val.ty;
-                if let Some(val) = val.try_eval_bits(tcx, param_env, ty) {
+                let size = match ty.sty {
+                    ty::Char => Size::from_bytes(4),
+                    ty::Int(ity) => {
+                        Integer::from_attr(&tcx, SignedInt(ity)).size()
+                    }
+                    ty::Uint(uty) => {
+                        Integer::from_attr(&tcx, UnsignedInt(uty)).size()
+                    }
+                    // per is_integral above
+                    _ => unreachable!(),
+                };
+                // This is purely an optimization -- try_eval_bits is a pretty expensive operation,
+                // as it invokes the layout_of query, but here we know that the type is a primitive,
+                // so we don't need all that complexity (hashing, caching, etc.). As such, try to
+                // skip it.
+                //
+                // FIXME: Is it possible for try_to_bits to fail here? There *are* other variants of
+                // ty::Const, but it seems like they might be impossible to encounter in match
+                // checking...
+                if let Some(val) = val.val.try_to_bits(size)
+                    .or_else(|| val.try_eval_bits(tcx, param_env, ty)) {
                     let bias = IntRange::signed_bias(tcx, ty);
                     let val = val ^ bias;
                     Some(IntRange { range: val..=val, ty })